Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPP tests #98

Open
8 of 16 tasks
Rombur opened this issue Apr 5, 2016 · 7 comments
Open
8 of 16 tasks

CPP tests #98

Rombur opened this issue Apr 5, 2016 · 7 comments

Comments

@Rombur
Copy link
Collaborator

Rombur commented Apr 5, 2016 •
edited
Loading

The following tests need to be improved:

  • test_energy_storage_device does not test ParallelRC (only SerialRC is tested)
  • test_ragone_chart does not test discharge with constant_load, discharge with constant_current and SeriesRC, discharge with constant_power and SeriesRC
  • test_resistor_capacitor_data does not test SeriesRC

The following functions need to be tested:

  • in deal.II/geometry.templates.h: foo<3>
  • in deal.II/post_processor.cc: extract_duration_and_average_power
  • in deal.II/post_processor.templates.h:
    • get(std::string const &key)
    • get_vector_keys()
    • check that the debug quantities and the debug solution are needed or if they can be removed. They are not currently tested.
  • in deal.II/supercapacitor.cc: no test in 3D
  • in deal.II/supercapacitor.h: SuperCapacitorInspector
  • in resistor_capacitor.cc:
    • reset x2
    • evolve_one_time_step_linear_current x2
    • evolve_one_time_step_linear_power x2
    • evolve_one_time_step_linear_power x2
@Rombur
Copy link
Collaborator Author

Rombur commented Apr 14, 2016

foo has been removed in the distributed branch.

@Rombur
Copy link
Collaborator Author

Rombur commented Apr 21, 2016

test_energy_storage_device fixed by #123

@Rombur
Copy link
Collaborator Author

Rombur commented Apr 27, 2016

extract_duration_and_average_power removed by #131

@dalg24
Copy link
Collaborator

dalg24 commented May 5, 2016

PR #148 fixed test_ragone_chart

@Rombur
Copy link
Collaborator Author

Rombur commented May 20, 2016

PR #160 fixed test_resistor_capacitor-2

@Rombur
Copy link
Collaborator Author

Rombur commented May 31, 2016

PR #168 removed reset

@Rombur
Copy link
Collaborator Author

Rombur commented Jun 23, 2016

PR #180 added a 3D test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dalg24 @Rombur