Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: toybox: lack of recursion #12

Open
kkarhan opened this issue Dec 13, 2023 · 5 comments
Open

BUG: toybox: lack of recursion #12

kkarhan opened this issue Dec 13, 2023 · 5 comments
Assignees
@kkarhan
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
OS/1337 "Core" Ed...

Comments

@kkarhan
Copy link
Contributor

kkarhan commented Dec 13, 2023

Currently, all commands included in toybox need to be called up by adding toybox before or else they fail.
@kkarhan kkarhan added bug Something isn't working enhancement New feature or request labels Dec 13, 2023
@kkarhan kkarhan added this to the OS/1337 "Core" Edition milestone Dec 13, 2023
@kkarhan kkarhan self-assigned this Dec 13, 2023
@kkarhan
Copy link
Contributor Author

kkarhan commented Dec 13, 2023

See TODO comment in commit

@kkarhan kkarhan removed their assignment Dec 13, 2023
@kkarhan kkarhan added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Dec 15, 2023
@sweetaibelle
Copy link
Contributor

Already done in the scripts rework, just not in the ones in the build folder.

@kkarhan kkarhan mentioned this issue Dec 17, 2023
Open
@kkarhan
Copy link
Contributor Author

kkarhan commented Dec 17, 2023

@sweetaibelle thanks for the info...

I propably need to build myself a new image and retest it...
I should close this issue once I rebuild a new floppy image...

@kkarhan kkarhan self-assigned this Dec 17, 2023
@kkarhan kkarhan moved this from Todo to In Progress in OS/1337 "CORE" Edition Dec 17, 2023
@kkarhan kkarhan moved this from In Progress to Testing in OS/1337 "CORE" Edition Dec 17, 2023
@kkarhan
Copy link
Contributor Author

kkarhan commented Dec 20, 2023

I really should use the stuff in scripts instead...

@kkarhan
Copy link
Contributor Author

kkarhan commented Jan 22, 2024

Already done in the scripts rework, just not in the ones in the build folder.
#12 (comment)

@sweetaibelle interestingly this didn't seem to have an effect when i built it from the scripts.

I wounder what I did wrong...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkarhan kkarhan

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
OS/1337 "CORE" Edition
Status: Testing
Milestone
OS/1337 "Core" Edition
Development

No branches or pull requests
2 participants
@sweetaibelle @kkarhan