Skip to content
This repository was archived by the owner on Oct 2, 2024. It is now read-only.
This repository was archived by the owner on Oct 2, 2024. It is now read-only.

Don't use -1 to mean "forever" in lockoutpolicy and passwordpolicy tests #189

@chisholm

Description

@chisholm

The relevant API uses DWORDs to represent many account policy related configuration options. The real system values should be used in items, not -1, which is an illegal value for a DWORD. See NetUserModalsGet().

We think -1 was originally used because the macro "TIMEQ_FOREVER" is defined in a system header as "((unsigned long) -1L)". -1 occurs as an implementation detail of the macro definition. Tests should not be defined in terms of these sorts of implementation details.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions