Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email verification should be there #3317

Open
yashgoyal0110 opened this issue Feb 1, 2025 · 17 comments · May be fixed by #3372
Open

Email verification should be there #3317

yashgoyal0110 opened this issue Feb 1, 2025 · 17 comments · May be fixed by #3372

Comments

@yashgoyal0110
Copy link

Currently there is no email verification on signup, that's why its also accepting invalid email, there should be some valid checks and even password has some checks (for example it should include uppercase, lowercase, numbers and special characters)

Image
@yashgoyal0110
Copy link
Author

@DonnieBLT what's your opinion

@DonnieBLT
Copy link
Collaborator

Sounds good, yes.

@yashgoyal0110
Copy link
Author

can i work on it?

@DonnieBLT
Copy link
Collaborator

Yes type /assign

@yashgoyal0110
Copy link
Author

/assign

Copy link
Contributor

github-actions bot commented Feb 1, 2025

Hello @yashgoyal0110! You've been assigned to OWASP-BLT/BLT issue #3317. You have 24 hours to complete a pull request.

@yashgoyal0110
Copy link
Author

and one more thing, OTP verification or just simple valid email check?

@DonnieBLT
Copy link
Collaborator

We have email confirmation sent through email - I think it will be good to also add a hidden email field and reject the form if it’s filled out by a bot

@yashgoyal0110
Copy link
Author

We have email confirmation sent through email - I think it will be good to also add a hidden email field and reject the form if it’s filled out by a bot

I think we should send an OTP or verification email to continue process, once user sign ups for validation purpose

@DonnieBLT
Copy link
Collaborator

We do send a verification email. We should delete these users and activity if they are not verified in 24 hours

Copy link
Contributor

github-actions bot commented Feb 3, 2025

⏰ This issue has been automatically unassigned due to 24 hours of inactivity.
The issue is now available for anyone to work on again.

@akdrin
Copy link

akdrin commented Feb 5, 2025

Can i work on it?
/assign

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Hello @akdrin! You've been assigned to OWASP-BLT/BLT issue #3317. You have 24 hours to complete a pull request.

@github-actions github-actions bot assigned akdrin and unassigned akdrin Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

⏰ This issue has been automatically unassigned due to 24 hours of inactivity.
The issue is now available for anyone to work on again.

1 similar comment
Copy link
Contributor

github-actions bot commented Feb 6, 2025

⏰ This issue has been automatically unassigned due to 24 hours of inactivity.
The issue is now available for anyone to work on again.

@tsu-ki
Copy link
Contributor

tsu-ki commented Feb 9, 2025

@DonnieBLT sir, I was trying to implement automatic deletion of users with unverified emails. To do so, I'll have to incorporate celery for periodic task running, I believe it'll take up quite some memory space, should I go ahead and use it?

@DonnieBLT
Copy link
Collaborator

We can have a daily Django management command do it

@tsu-ki tsu-ki linked a pull request Feb 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants