Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update selections endpoint description #2396

Closed
3 tasks
xenowits opened this issue Jul 4, 2023 · 1 comment
Closed
3 tasks

Update selections endpoint description #2396

xenowits opened this issue Jul 4, 2023 · 1 comment
Assignees
@dB2510 @xenowits
Labels
protocol Protocol Team tickets

Comments

@xenowits
Copy link
Contributor

xenowits commented Jul 4, 2023 •
edited
Loading

🎯 Problem to be solved

The client teams implementing aggregations have discussed the possibility of querying selections endpoints at the "start of an epoch" rather than at the "start of a slot".

Charon already supports this and "query at start of an epoch" would enable easy implementation in consensus clients. However, we should mention this explicitly in the beacon API spec since it is unclear currently.

🛠️ Proposed solution

  • Raise a PR to update the beacon-API specs repo
  • Update the implementations guide to explicitly state that client teams must query at epoch start
  • Share the link to this PR with the client teams

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label Jul 4, 2023
@dB2510
Copy link
Contributor

dB2510 commented Oct 31, 2023

Completed and PR has been raised: ethereum/beacon-APIs#368

@dB2510 dB2510 closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

@xenowits xenowits

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dB2510 @xenowits