From 3ccb801b350ff297e53f255991cff65c1c21ddbc Mon Sep 17 00:00:00 2001
From: Ofek Shilon <ofekshilon@gmail.com>
Date: Sat, 11 May 2024 21:16:58 +0300
Subject: [PATCH] Don't trust `hasStackUsageOutput`/`hasOptOutput` - they can
 be true for compilations that failed and really have no
 `stackUsageOutput`/`optOutput`

---
 static/panes/opt-view.ts         | 3 ++-
 static/panes/stack-usage-view.ts | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/static/panes/opt-view.ts b/static/panes/opt-view.ts
index 13002a2a7c5..29a334ad928 100644
--- a/static/panes/opt-view.ts
+++ b/static/panes/opt-view.ts
@@ -124,7 +124,8 @@ export class Opt extends MonacoPane<monaco.editor.IStandaloneCodeEditor, OptStat
         }
 
         this.editor.setValue(unwrap(result.source));
-        if (result.hasOptOutput) {
+        if (result.optOutput) {
+            // result.hasOptOutput might be true for failed compilations
             this.optRemarks = result.optOutput;
             this.showOptRemarks();
         }
diff --git a/static/panes/stack-usage-view.ts b/static/panes/stack-usage-view.ts
index 05c0e7127a3..327a11a25b2 100644
--- a/static/panes/stack-usage-view.ts
+++ b/static/panes/stack-usage-view.ts
@@ -88,9 +88,11 @@ export class StackUsage extends MonacoPane<monaco.editor.IStandaloneCodeEditor,
     override onCompileResult(id: number, compiler: CompilerInfo, result: CompilationResult) {
         if (this.compilerInfo.compilerId !== id || !this.isCompilerSupported) return;
         this.editor.setValue(unwrap(result.source));
-        if (result.hasStackUsageOutput) {
-            this.showStackUsageResults(unwrap(result.stackUsageOutput));
+        if (result.stackUsageOutput) {
+            // result.hasStackUsageOutput might be true for failed compilations
+            this.showStackUsageResults(result.stackUsageOutput);
         }
+
         // TODO: This is inelegant again. Previously took advantage of fourth argument for the compileResult event.
         const lang = compiler.lang === 'c++' ? 'cpp' : compiler.lang;
         const model = this.editor.getModel();