Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - address-form.tpl needs validation class #419

Open
Shoprunners opened this issue Aug 5, 2024 · 2 comments
Open

🐛 [BUG] - address-form.tpl needs validation class #419

Shoprunners opened this issue Aug 5, 2024 · 2 comments
Labels
bug Something isn't working minor theme

Comments

@Shoprunners
Copy link

Description

The address-form.tpl 's form should have the "needs-validation" class. With this class, the trim function for address fields will be called.

Node.js version

v14

php version

v8.1

OS and it's version

ALL

Browsers

No response

Required module/theme

theme

Reproduction steps

1. Add an address in the frontend
2. Add a "space" to a name / street field at the end
3. Save
4. Validation error will occur.

With the class, the "on blur" -> trim() will be called, like in the personal information form.

Logs

No response

@Shoprunners Shoprunners added the bug Something isn't working label Aug 5, 2024
@Oksydan
Copy link
Owner

Oksydan commented Aug 19, 2024

Hi @Shoprunners,

thank you for creating an issue. I am adding this to roadmap.

@maofree
Copy link

maofree commented Aug 23, 2024

Hi
this fix is necessary into two files

checkout/_partials/steps/addresses.tpl
replacing this line

to

and into
customer/_partials/address-form.tpl
using this line

bye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor theme
Projects
Development

No branches or pull requests

3 participants