-
Notifications
You must be signed in to change notification settings - Fork 3
Description
Hello Oleg, I analyzed this package for the last 2 days. I was developing my own version then thought what a waste of time, probably someone made a better version already :) In my opinion, this is a great solution but lacking a few major things. Before implementing them, I want to make sure you're not already working on them (it would be a waste of labor, wouldn't it?) or you even want to implement the things I propose.
Here is my list:
1 - A probability node. I know this is not an AI package but having a built in randomize node would be cool to quickly eliminate repeated conversations in the game.
2 - A sentence and answer node put into one piece. It's easy to implement and seeing the question in the screen while answering it can be useful.
3 - A seperate function call node. This can be especially useful when combined with probability node mentioned above.
4 - Save wrappers. Maybe an interface like ISaveWrapper and a editor dropdown that gathers all the classes that implements that interface and when game starts, appropriate manager creates an instance of selected save wrapper. Default wrapper would be PlayerPrefsSaveWrapper of course and that way this package can be used with a huge variety of save-load solutions found in the asset store.
5 - Zoom in-out functionality. I have no idea how to implement this tbh but would be so cool to have this behaviour.
6 - There is no way to remove listener from DialogBehaviour._onDialogFinished right now, small but important detail.
7 - The way DialogBehaviour and DialogDisplayer implemented it's impossible to extend functionality (for example using a scaling animation when text is shown) without modifying existing code. I have some ideas how to restructure it but it's your decision in the end to either keep them monolith and easy to use this way or make a refactoring of these two that allows for flexibility.
If you greenlight all or some of the things from the list, I can work on them and merge them into this repository or I will probably implement them in my own fork.
Keep up fantastic work!