From cdd18b638bf519507e63340b08c26db9c648effb Mon Sep 17 00:00:00 2001 From: Olivier Zalmanski <88216225+OlivierZal@users.noreply.github.com> Date: Wed, 2 Oct 2024 01:04:28 +0200 Subject: [PATCH] improve setAta error handling --- package-lock.json | 4 ++-- package.json | 2 +- src/decorators/updateDevices.ts | 3 +++ src/facades/base_super_device.ts | 3 --- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index cd632dd..e0b3573 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@olivierzal/melcloud-api", - "version": "11.0.1", + "version": "11.0.2", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@olivierzal/melcloud-api", - "version": "11.0.1", + "version": "11.0.2", "license": "ISC", "dependencies": { "axios": "^1.7.7", diff --git a/package.json b/package.json index 1704658..ac67c0c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@olivierzal/melcloud-api", - "version": "11.0.1", + "version": "11.0.2", "description": "MELCloud API for Node.js", "keywords": [ "melcloud", diff --git a/src/decorators/updateDevices.ts b/src/decorators/updateDevices.ts index d3bce69..ed56283 100644 --- a/src/decorators/updateDevices.ts +++ b/src/decorators/updateDevices.ts @@ -21,6 +21,9 @@ export default ( ...args: unknown[] ) { const [arg] = args + if (arg !== null && typeof arg === 'object' && !Object.keys(arg).length) { + throw new Error('No data to set') + } const data = await target.call(this, arg) const newData = String(context.name) === 'SetPower' ? diff --git a/src/facades/base_super_device.ts b/src/facades/base_super_device.ts index 5f33d0f..a5e41f1 100644 --- a/src/facades/base_super_device.ts +++ b/src/facades/base_super_device.ts @@ -38,9 +38,6 @@ export default abstract class< public async setAta( state: GroupAtaState, ): Promise { - if (!Object.keys(state).length) { - throw new Error('No data to set') - } try { return ( await this.api.setAta({