Staging: DEx release bugs/issues/comments

[achamely]

Track all reported issues/bugs/comments on the new DEx interface and their resolution

Confirmed

• Upgrade websocket library for stability and to remove flash usage
• Move all periodic Orderbook updates to websockets
• Move all periodic Balance updates to websockets
• Update websocket code to have auto reconnect and failover handling
• Seller's existing active offers table not cleared when order confirmed (duplicate entry)
• (bug/feature) add word pending under active offer (change row color to blue?)
• add pair name to active offer title
• (bug) round up buy order form calculations and round down sell order form calculations to display proper effective price
• Change 'Active Offers' to 'My Active Offers'
• Change how failed balance lookups operate (Return 0 instead of -555)
• move 'you don't have any active offers' to replace entire chart/table when its empty for my active offers (save some space)
• Add 'switch / invert markets' toggle
• highlight 2nd pair in market list when selected (actually moved the invert button to be an indicator of the active pair )
• show last price not changed price in overview
• fix/make sure all active markets are displayed
• Change price per coin to price per token in active offers
• Fix pending tx recording in db to respect divisibility of property
• number formatting markets list
• Change market current price to be best price of both, ask/sell then ( if ask=0 show buy price)
• Display bug for new wallets/0 balance wallets on start markets page/accept offer page fixed
• Success/Error tx info moved to tx modal instead of hidden at top of page
• Rename 'Trade / My Offers -> BTC/OMNI and My BTC/OMNI Offers' per Marv's suggestions
• Rearrange the exchange tabs so the omnidex is the first/default option
• Overall order form validation updated
• Fix form validation/calculation on the orderbook. It was not respecting Indivisible properties properly (user could submit offer for 1.3 maidsafe etc.. and it would be truncated by omnicore to 1)
• 'Adding watch only address causes unusual orderbook behavior (per marv's description Staging: DEx release bugs/issues/comments #1396 (comment))
• (Improvement) Add tooltip to column headings to clarify definitions
• (Bug/Display issue) Users Active offers may be displaying different pricing info than orderbook display (example in post Staging: DEx release bugs/issues/comments #1396 (comment))
  Needs Testing
• (Bug) Overview page chart/overall balance total may be incorrect
• Add Form Validation on Start new market
• (Bug) Start new market fix desired property list to filter selling property out
• Add property name to omnidex confirmation modal
• (Bug) Websockets orderbook not including pending transactions.
• Tweak pending tx tooltip wording on overviews
• (Bug) Indivisible properties could display decimal amounts in omnidex
• Add tooltips to users order section
• 'Your Balance' display on the sell/buy orderbook forms can still display 1e8 formatting (possible resolved)

In Progress

• (Bugs) Cleanup Market Charts
• (feature) Add reset button for field data on form
• (Improvement) possible to add invert button between order forms
• Add option to filter non promoted property?

[achamely]

Marv Schneider - uploaded and commented on an image: Pasted image at 2016-11-16, 4:26 PM
why are the two amounts different, but the totals are the same?

[achamely]

Marv Schneider uploaded and commented on an image: Pasted image at 2016-11-17, 5:37 PM
Unexpected behavior in Ff on staging: I added a watch-only address that was listed as the address for an Omni/USDT ask. I wanted to see if that ask would show up as one of “my offers” if I don’t have the private key. The new address and its balances showed up immediately on My Addresses - good. But for some reason, the exchange page now says “No offers" in the order book for ALL pairs. I’ll try logging out and in to see if that makes the order. That wallet says “No offers” even in Chrome. Other wallets show the order book entries as expected - in Chrome and Ff.

[marvgmail]

For the record - have to correctly display, and accept input, for indivisible properties.