Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #366: Add an endpoint to retrieve the stops of a particular agency #367

Merged

Conversation

AngeloAvv
Copy link
Contributor

Adds feature described in #366

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024

CLA assistant check
All committers have signed the CLA.

@aaronbrethorst
Copy link
Member

@AngeloAvv thank you for adding this! Can I ask you to add one or two basic unit tests that exercise the functionality you've added? I'll follow up on this with a full code review soon, and we're actively working on getting new JARs and WARs published!

@AngeloAvv
Copy link
Contributor Author

@aaronbrethorst done!

@aaronbrethorst
Copy link
Member

@AngeloAvv apologies for the delay. The CI is failing with the error:

Error: Failed to execute goal com.mycila:license-maven-plugin:3.0:check (default) on project onebusaway-transit-data-federation: Some files do not have the expected license header -> [Help 1]

@aaronbrethorst
Copy link
Member

@AngeloAvv I haven't forgotten about you or this PR! Just need to get my development machine set back up to test this. Sorry it's taking so long!

@aaronbrethorst
Copy link
Member

@AngeloAvv thank you for your patience! I am finally ready to validate this and get it merged. Expect to hear more from me shortly.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works great! nice work :)

@aaronbrethorst aaronbrethorst merged commit 8628b85 into OneBusAway:master Sep 8, 2024
2 checks passed
@aaronbrethorst
Copy link
Member

Here's the example output for the Unitrans agency in Davis CA for Ahmed.

stops-for-agency_unitrans.json

@AngeloAvv
Copy link
Contributor Author

@aaronbrethorst thank you so much! Do you have an ETA for release 2.5.13? Where can I follow any updates?

@AngeloAvv AngeloAvv deleted the features/stops-for-agency branch September 9, 2024 10:27
@Ahmedhossamdev
Copy link
Member

Hi @AngeloAvv,

Nice work! <3

I have a small question: to add this endpoint to our SDKs, are there any other parameters in the URL or just agencyId?

@aaronbrethorst
Copy link
Member

@AngeloAvv as soon as I can. I’m brand new to the Java ecosystem and learning as I go. If you have experience with publishing to maven central I’d love to get your help with setting things up to publish to them.

@Ahmedhossamdev you are correct, just that one parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants