-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #366: Add an endpoint to retrieve the stops of a particular agency #367
Issue #366: Add an endpoint to retrieve the stops of a particular agency #367
Conversation
@AngeloAvv thank you for adding this! Can I ask you to add one or two basic unit tests that exercise the functionality you've added? I'll follow up on this with a full code review soon, and we're actively working on getting new JARs and WARs published! |
@aaronbrethorst done! |
@AngeloAvv apologies for the delay. The CI is failing with the error:
|
@AngeloAvv I haven't forgotten about you or this PR! Just need to get my development machine set back up to test this. Sorry it's taking so long! |
@AngeloAvv thank you for your patience! I am finally ready to validate this and get it merged. Expect to hear more from me shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works great! nice work :)
Here's the example output for the Unitrans agency in Davis CA for Ahmed. |
@aaronbrethorst thank you so much! Do you have an ETA for release 2.5.13? Where can I follow any updates? |
Hi @AngeloAvv, Nice work! <3 I have a small question: to add this endpoint to our SDKs, are there any other parameters in the URL or just agencyId? |
@AngeloAvv as soon as I can. I’m brand new to the Java ecosystem and learning as I go. If you have experience with publishing to maven central I’d love to get your help with setting things up to publish to them. @Ahmedhossamdev you are correct, just that one parameter. |
Adds feature described in #366