From 2b31b2131327891a4a2d4132a5f81943bdd60603 Mon Sep 17 00:00:00 2001 From: DongGeun Date: Fri, 20 Jun 2025 13:07:27 +0900 Subject: [PATCH] =?UTF-8?q?refactor=20:=20=EC=98=88=EC=99=B8=EC=B2=98?= =?UTF-8?q?=EB=A6=AC=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../domain/user/repository/UserRepository.java | 3 +-- .../onederful/domain/user/service/UserService.java | 13 ++++++------- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/example/onederful/domain/user/repository/UserRepository.java b/src/main/java/com/example/onederful/domain/user/repository/UserRepository.java index fa642f7..889e6c9 100644 --- a/src/main/java/com/example/onederful/domain/user/repository/UserRepository.java +++ b/src/main/java/com/example/onederful/domain/user/repository/UserRepository.java @@ -6,8 +6,7 @@ import java.util.Optional; public interface UserRepository extends JpaRepository { - boolean existsByEmail(String email); - boolean existsByUsername(String username); + Optional findByEmail(String email); Optional findByUsername(String username); } diff --git a/src/main/java/com/example/onederful/domain/user/service/UserService.java b/src/main/java/com/example/onederful/domain/user/service/UserService.java index 4e1520f..f6c7dcb 100644 --- a/src/main/java/com/example/onederful/domain/user/service/UserService.java +++ b/src/main/java/com/example/onederful/domain/user/service/UserService.java @@ -32,15 +32,14 @@ public class UserService { public UserResponseDto signup(RequestDto dto){ // 이메일 중복 확인 - if(userRepository.existsByEmail(dto.getEmail())){ - throw new CustomException(ErrorCode.DUPLICATE_EMAIL); - } - + userRepository.findByEmail(dto.getEmail()).ifPresent( + user -> {throw new CustomException(ErrorCode.DUPLICATE_EMAIL);} + ); // 아이디 중복 확인 - if(userRepository.existsByUsername(dto.getUsername())){ - throw new CustomException(ErrorCode.DUPLICATE_USER); - } + userRepository.findByUsername(dto.getUsername()).ifPresent( + user -> {throw new CustomException(ErrorCode.DUPLICATE_USER);} + ); // Dto → Entity User user = UserMapper.user(dto);