feat: Test adding or removing property

Author: danilofuchs

core/src/main/java/org/openapitools/openapidiff/core/model/schema/ChangedMaxItems.java

@@ -20,9 +20,6 @@ public DiffResult isChanged() {
     if (oldValue == newValue) {
       return DiffResult.NO_CHANGES;
     }
-    if (oldValue == null && newValue == null) {
-      return DiffResult.NO_CHANGES;
-    }
     if (oldValue == null || newValue == null) {
       return DiffResult.COMPATIBLE;
     }

core/src/main/java/org/openapitools/openapidiff/core/model/schema/ChangedMinItems.java

@@ -20,9 +20,6 @@ public DiffResult isChanged() {
     if (oldValue == newValue) {
       return DiffResult.NO_CHANGES;
     }
-    if (oldValue == null && newValue == null) {
-      return DiffResult.NO_CHANGES;
-    }
     if (oldValue == null || newValue == null) {
       return DiffResult.COMPATIBLE;
     }

core/src/test/java/org/openapitools/openapidiff/core/SchemaDiffTest.java

@@ -180,6 +180,26 @@ public void changeMinMaxItemsHandling() {
     assertThat(props.get("field4").getMaxItems().isIncompatible()).isTrue();
     assertThat(props.get("field4").getMaxItems().getOldValue()).isEqualTo(100);
     assertThat(props.get("field4").getMaxItems().getNewValue()).isEqualTo(90);
+
+    // Check removal of minItems
+    assertThat(props.get("field5").getMinItems().isCompatible()).isTrue();
+    assertThat(props.get("field5").getMinItems().getOldValue()).isEqualTo(1);
+    assertThat(props.get("field5").getMinItems().getNewValue()).isNull();
+
+    // Check removal of maxItems
+    assertThat(props.get("field5").getMaxItems().isCompatible()).isTrue();
+    assertThat(props.get("field5").getMaxItems().getOldValue()).isEqualTo(100);
+    assertThat(props.get("field5").getMaxItems().getNewValue()).isNull();
+
+    // Check addition of minItems
+    assertThat(props.get("field6").getMinItems().isCompatible()).isTrue();
+    assertThat(props.get("field6").getMinItems().getOldValue()).isNull();
+    assertThat(props.get("field6").getMinItems().getNewValue()).isEqualTo(1);
+
+    // Check addition of maxItems
+    assertThat(props.get("field6").getMaxItems().isCompatible()).isTrue();
+    assertThat(props.get("field6").getMaxItems().getOldValue()).isNull();
+    assertThat(props.get("field6").getMaxItems().getNewValue()).isEqualTo(100);
   }
 
   @Test // issue #482

core/src/test/resources/schemaDiff/schema-min-max-items-diff-1.yaml

@@ -46,3 +46,13 @@ components:
             type: string
           minItems: 1
           maxItems: 100
+        field5:
+          type: array
+          items:
+            type: string
+          minItems: 1
+          maxItems: 100
+        field6:
+          type: array
+          items:
+            type: string

core/src/test/resources/schemaDiff/schema-min-max-items-diff-2.yaml

@@ -46,3 +46,13 @@ components:
             type: string
           minItems: 1
           maxItems: 90
+        field5:
+          type: array
+          items:
+            type: string
+        field6:
+          type: array
+          items:
+            type: string
+          minItems: 1
+          maxItems: 100