Skip to content

Commit 7715afd

Browse files
committed
WIP response header changes handling
1 parent 3584a8e commit 7715afd

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

core/src/test/java/org/openapitools/openapidiff/core/ResponseHeaderDiffTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,17 +58,16 @@ public void testResponseHeadersRequiredChanges() {
5858
assertThat(changedHeaders).containsKey("x-header-required-changed");
5959
}
6060

61-
// TODO response schema type changes are not handled
62-
// @Test
63-
public void testResponseHeadersSchemaChanges() {
61+
@Test
62+
public void testResponseHeadersExplodeChanges() {
6463
ChangedOpenApi changedOpenApi = OpenApiCompare.fromLocations(OPENAPI_DOC1, OPENAPI_DOC2);
6564
ChangedHeaders changedResponseHeaders =
66-
getChangedResponseHeaders(changedOpenApi, GET, "/response/headers/schema", "200");
65+
getChangedResponseHeaders(changedOpenApi, GET, "/response/headers/explode", "200");
6766

6867
assertThat(changedResponseHeaders).isNotNull();
6968
Map<String, ChangedHeader> changedHeaders = changedResponseHeaders.getChanged();
7069

71-
assertThat(changedHeaders).containsKey("x-header-schema-changed");
70+
assertThat(changedHeaders).containsKey("x-header-explode-changed");
7271
}
7372

7473
@Test // issue #485

core/src/test/resources/response_header_1.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,14 @@ paths:
5050
type: string
5151
content:
5252
application/json: { }
53-
/response/headers/schema:
53+
/response/headers/explode:
5454
get:
5555
responses:
5656
'200':
5757
description: some description
5858
headers:
59-
x-header-schema-changed:
59+
x-header-explode-changed:
60+
explode: false
6061
schema:
6162
type: string
6263
content:

core/src/test/resources/response_header_2.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,15 @@ paths:
5050
type: string
5151
content:
5252
application/json: { }
53-
/response/headers/schema:
53+
/response/headers/explode:
5454
get:
5555
responses:
5656
'200':
5757
description: some description
5858
headers:
59-
x-header-schema-changed:
59+
x-header-explode-changed:
60+
explode: true
6061
schema:
61-
type: int64
62+
type: string
6263
content:
6364
application/json: { }

0 commit comments

Comments
 (0)