From 328f969e16ffabe9b1b40aeacc1cb0174393476a Mon Sep 17 00:00:00 2001 From: Foulques du Peloux Date: Wed, 4 Feb 2026 17:08:25 +0100 Subject: [PATCH 1/3] [php-symfony] do not interpret sequential escape --- .../main/resources/php-symfony/api_input_validation.mustache | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/openapi-generator/src/main/resources/php-symfony/api_input_validation.mustache b/modules/openapi-generator/src/main/resources/php-symfony/api_input_validation.mustache index ab8d418f9b76..330f113e976f 100644 --- a/modules/openapi-generator/src/main/resources/php-symfony/api_input_validation.mustache +++ b/modules/openapi-generator/src/main/resources/php-symfony/api_input_validation.mustache @@ -42,7 +42,7 @@ $asserts[] = new Assert\Type("\{{modelPackage}}\{{dataType}}"); {{/isEnumRef}} {{^isEnumRef}} - $asserts[] = new Assert\Type("{{dataType}}"); + $asserts[] = new Assert\Type('{{dataType}}'); {{^isPrimitiveType}} $asserts[] = new Assert\Valid(); {{/isPrimitiveType}} From 2ea5f03b368b57836bf740c1406ca89f2214d4fd Mon Sep 17 00:00:00 2001 From: Foulques du Peloux Date: Wed, 4 Feb 2026 17:51:47 +0100 Subject: [PATCH 2/3] chore: update samples --- .../Controller/PetController.php | 26 +++++++++---------- .../Controller/StoreController.php | 6 ++--- .../Controller/UserController.php | 14 +++++----- 3 files changed, 23 insertions(+), 23 deletions(-) diff --git a/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/PetController.php b/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/PetController.php index 5fcf3f57c6d0..c05f8920b912 100644 --- a/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/PetController.php +++ b/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/PetController.php @@ -97,7 +97,7 @@ public function addPetAction(Request $request) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("OpenAPI\Server\Model\Pet"); + $asserts[] = new Assert\Type('OpenAPI\Server\Model\Pet'); $asserts[] = new Assert\Valid(); $response = $this->validate($pet, $asserts); if ($response instanceof Response) { @@ -170,13 +170,13 @@ public function deletePetAction(Request $request, $petId) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("int"); + $asserts[] = new Assert\Type('int'); $response = $this->validate($petId, $asserts); if ($response instanceof Response) { return $response; } $asserts = []; - $asserts[] = new Assert\Type("string"); + $asserts[] = new Assert\Type('string'); $response = $this->validate($apiKey, $asserts); if ($response instanceof Response) { return $response; @@ -250,7 +250,7 @@ public function downloadFileAction(Request $request, $petId) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("int"); + $asserts[] = new Assert\Type('int'); $response = $this->validate($petId, $asserts); if ($response instanceof Response) { return $response; @@ -496,7 +496,7 @@ public function getPetByIdAction(Request $request, $petId) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("int"); + $asserts[] = new Assert\Type('int'); $response = $this->validate($petId, $asserts); if ($response instanceof Response) { return $response; @@ -573,7 +573,7 @@ public function petAgeAction(Request $request, $petId) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("int"); + $asserts[] = new Assert\Type('int'); $response = $this->validate($petId, $asserts); if ($response instanceof Response) { return $response; @@ -646,7 +646,7 @@ public function petAvailableForSaleAction(Request $request, $petId) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("int"); + $asserts[] = new Assert\Type('int'); $response = $this->validate($petId, $asserts); if ($response instanceof Response) { return $response; @@ -731,7 +731,7 @@ public function updatePetAction(Request $request) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("OpenAPI\Server\Model\Pet"); + $asserts[] = new Assert\Type('OpenAPI\Server\Model\Pet'); $asserts[] = new Assert\Valid(); $response = $this->validate($pet, $asserts); if ($response instanceof Response) { @@ -808,19 +808,19 @@ public function updatePetWithFormAction(Request $request, $petId) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("int"); + $asserts[] = new Assert\Type('int'); $response = $this->validate($petId, $asserts); if ($response instanceof Response) { return $response; } $asserts = []; - $asserts[] = new Assert\Type("string"); + $asserts[] = new Assert\Type('string'); $response = $this->validate($name, $asserts); if ($response instanceof Response) { return $response; } $asserts = []; - $asserts[] = new Assert\Type("string"); + $asserts[] = new Assert\Type('string'); $response = $this->validate($status, $asserts); if ($response instanceof Response) { return $response; @@ -900,13 +900,13 @@ public function uploadFileAction(Request $request, $petId) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("int"); + $asserts[] = new Assert\Type('int'); $response = $this->validate($petId, $asserts); if ($response instanceof Response) { return $response; } $asserts = []; - $asserts[] = new Assert\Type("string"); + $asserts[] = new Assert\Type('string'); $response = $this->validate($additionalMetadata, $asserts); if ($response instanceof Response) { return $response; diff --git a/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/StoreController.php b/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/StoreController.php index 79b38c784f41..699a0ffd7337 100644 --- a/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/StoreController.php +++ b/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/StoreController.php @@ -75,7 +75,7 @@ public function deleteOrderAction(Request $request, $orderId) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("string"); + $asserts[] = new Assert\Type('string'); $response = $this->validate($orderId, $asserts); if ($response instanceof Response) { return $response; @@ -212,7 +212,7 @@ public function getOrderByIdAction(Request $request, $orderId) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("int"); + $asserts[] = new Assert\Type('int'); $asserts[] = new Assert\GreaterThanOrEqual(1); $asserts[] = new Assert\LessThanOrEqual(5); $response = $this->validate($orderId, $asserts); @@ -298,7 +298,7 @@ public function placeOrderAction(Request $request) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("OpenAPI\Server\Model\Order"); + $asserts[] = new Assert\Type('OpenAPI\Server\Model\Order'); $asserts[] = new Assert\Valid(); $response = $this->validate($order, $asserts); if ($response instanceof Response) { diff --git a/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/UserController.php b/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/UserController.php index fac6cc022507..dee9a83a55d3 100644 --- a/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/UserController.php +++ b/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/UserController.php @@ -87,7 +87,7 @@ public function createUserAction(Request $request) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("OpenAPI\Server\Model\User"); + $asserts[] = new Assert\Type('OpenAPI\Server\Model\User'); $asserts[] = new Assert\Valid(); $response = $this->validate($user, $asserts); if ($response instanceof Response) { @@ -316,7 +316,7 @@ public function deleteUserAction(Request $request, $username) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("string"); + $asserts[] = new Assert\Type('string'); $response = $this->validate($username, $asserts); if ($response instanceof Response) { return $response; @@ -391,7 +391,7 @@ public function getUserByNameAction(Request $request, $username) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("string"); + $asserts[] = new Assert\Type('string'); $response = $this->validate($username, $asserts); if ($response instanceof Response) { return $response; @@ -469,7 +469,7 @@ public function loginUserAction(Request $request) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("string"); + $asserts[] = new Assert\Type('string'); $asserts[] = new Assert\Regex("/^[a-zA-Z0-9]+[a-zA-Z0-9\\.\\-_]*[a-zA-Z0-9]+$/"); $response = $this->validate($username, $asserts); if ($response instanceof Response) { @@ -477,7 +477,7 @@ public function loginUserAction(Request $request) } $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("string"); + $asserts[] = new Assert\Type('string'); $response = $this->validate($password, $asserts); if ($response instanceof Response) { return $response; @@ -609,14 +609,14 @@ public function updateUserAction(Request $request, $username) // Validate the input values $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("string"); + $asserts[] = new Assert\Type('string'); $response = $this->validate($username, $asserts); if ($response instanceof Response) { return $response; } $asserts = []; $asserts[] = new Assert\NotNull(); - $asserts[] = new Assert\Type("OpenAPI\Server\Model\User"); + $asserts[] = new Assert\Type('OpenAPI\Server\Model\User'); $asserts[] = new Assert\Valid(); $response = $this->validate($user, $asserts); if ($response instanceof Response) { From c57b655ed3b4bcfb4f319e3fe8246dee8e38c7e1 Mon Sep 17 00:00:00 2001 From: Foulques du Peloux Date: Mon, 9 Feb 2026 11:32:04 +0100 Subject: [PATCH 3/3] refactor: add missing return type --- .../petstore/php-symfony/SymfonyBundle-php/Tests/AppKernel.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/server/petstore/php-symfony/SymfonyBundle-php/Tests/AppKernel.php b/samples/server/petstore/php-symfony/SymfonyBundle-php/Tests/AppKernel.php index 2ce8342f343f..99b37dc0a66a 100644 --- a/samples/server/petstore/php-symfony/SymfonyBundle-php/Tests/AppKernel.php +++ b/samples/server/petstore/php-symfony/SymfonyBundle-php/Tests/AppKernel.php @@ -22,7 +22,7 @@ public function registerBundles(): iterable * @inheritDoc * @throws \Exception */ - public function registerContainerConfiguration(LoaderInterface $loader) + public function registerContainerConfiguration(LoaderInterface $loader): void { $loader->load(__DIR__.'/test_config.yaml'); }