From 7dfe2d59d99b9fc1e80e2cea29a1596bd5160436 Mon Sep 17 00:00:00 2001 From: Stephanya Casanova <stephanya.casanova@filigran.io> Date: Tue, 21 Jan 2025 15:52:29 +0100 Subject: [PATCH] [backend/frontend] Clean --- .../opencti-graphql/src/modules/xtm/xtm-domain.js | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/opencti-platform/opencti-graphql/src/modules/xtm/xtm-domain.js b/opencti-platform/opencti-graphql/src/modules/xtm/xtm-domain.js index 71c1f4dcbc8d2..1be9e40ce4fc4 100644 --- a/opencti-platform/opencti-graphql/src/modules/xtm/xtm-domain.js +++ b/opencti-platform/opencti-graphql/src/modules/xtm/xtm-domain.js @@ -394,11 +394,19 @@ export const generateOpenBasScenarioWithInjectPlaceholders = async ( if (filteredObasAttackPatterns.length === 0) { hasInjectPlaceholders = false; - attackPatternsNotAvailableInOpenBAS.push(attackPatternsMitreIds); - logApp.info(`[OPENCTI-MODULE][XTM] No attack patterns available on OpenBAS linked to these Mitre ids : ${attackPatternsMitreIds.join(', ')}`); + let attackPatternsForPlaceholders = attackPatternsMitreIds; + if (attackPatternsMitreIds.length === 0) { + const attackPatternsNames = finalAttackPatterns.filter((n) => isNotEmptyField(n.name)).map((n) => n.name); + attackPatternsForPlaceholders = attackPatternsNames; + attackPatternsNotAvailableInOpenBAS.push(attackPatternsNames); + logApp.info(`[OPENCTI-MODULE][XTM] No external ID for : ${attackPatternsNames.join(', ')}`); + } else { + attackPatternsNotAvailableInOpenBAS.push(attackPatternsMitreIds); + logApp.info(`[OPENCTI-MODULE][XTM] No attack patterns available on OpenBAS linked to these Mitre ids : ${attackPatternsMitreIds.join(', ')}`); + } if (simulationType !== 'simulated') { hasInjectPlaceholders = true; - attackPatternsMitreIds.forEach((attackNotAvailable) => { + attackPatternsForPlaceholders.forEach((attackNotAvailable) => { createAndInjectScenarioPromises.push(generatePlaceholder( attackNotAvailable, platforms,