Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bool VariableLengthArray constructor taking iterators is inconsistent with type T VLA #75

Closed
skeetsaz opened this issue Oct 26, 2023 · 1 comment
Closed

bool VariableLengthArray constructor taking iterators is inconsistent with type T VLA #75

skeetsaz opened this issue Oct 26, 2023 · 1 comment

Comments

@skeetsaz
Copy link
Contributor

T

    VariableLengthArray(InputIt first, InputIt last, size_type max_size_max, const allocator_type& alloc)
    VariableLengthArray(InputIt first, InputIt last, const allocator_type& alloc)

bool

    VariableLengthArray(InputIt               first,
                        InputIt               last,
                        const size_type       length,
                        size_type             max_size_max,
                        const allocator_type& alloc)
    VariableLengthArray(InputIt first, InputIt last, const size_type length, const allocator_type& alloc)

The bool ones should be changed to remove the length arg, similar in spirit to std::vector (5) constructor (https://en.cppreference.com/w/cpp/container/vector/vector)
@skeetsaz
Copy link
Contributor Author

skeetsaz commented Nov 3, 2023

Fixed by #76

@skeetsaz skeetsaz closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skeetsaz