Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line tests to include min/max values #984

Open
huss opened this issue Aug 4, 2023 · 0 comments
Open

line tests to include min/max values #984

huss opened this issue Aug 4, 2023 · 0 comments
Labels
assigned the issue is currently being worked on by a developer p-medium-priority t-enhancement This issues tracks a potential improvement to the software
Milestone

Comments

@huss
Copy link
Member

huss commented Aug 4, 2023

Is your feature request related to a problem? Please describe.

PR #975 added error bars to the graphics. The line reading tests, many in src/server/test/web/readings.js, are simply ignoring the returned min/max. Tests need to be enhanced to also test min/max.

Describe the solution you'd like

The design document needs to be updated, the expected data needs to be updates, the spreadsheet to calculated expected values needs to be updated and the tests then need to check the new values. The expected value data should use the same format as the export of line data with min/max values.

Describe alternatives you've considered

We don't do automated testing. For now, that is where we are at but this should not continue too long.

Additional context

@huss can help with the expected values and spreadsheets if that is desired.

@huss huss added t-enhancement This issues tracks a potential improvement to the software p-medium-priority labels Aug 4, 2023
@huss huss added this to the 1.1 release milestone Aug 4, 2023
@huss huss mentioned this issue Aug 4, 2023
4 tasks
@huss huss added the assigned the issue is currently being worked on by a developer label Feb 16, 2024
@alfarj83 alfarj83 mentioned this issue Feb 22, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned the issue is currently being worked on by a developer p-medium-priority t-enhancement This issues tracks a potential improvement to the software
Projects
None yet
Development

No branches or pull requests

1 participant