You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The worker's top level execute function has a few places where it might potentially throw.
This would result in the worker crashing and all runs in progess getting lost.
This is obviously quite severe but it's not entirely clear what we should do. The worker has an obligation to try and finish all outstanding work and report back to lightnig.
For example: failure to join the run channel will result in an unhandled exception. At this point something is very wrong. I don't think we can report back to Lightning yet because we've not even been able to join the comms channel (or we were kicked out). So the run is probably lost at this point. We should probably kill the whole worker (but give existing runs a chance to finish)
There are probably a few other equally nefarious places where an error will result in the whole worker crashing. It's a very sensitive bit of code with a lot of asyncrhonicity and dependencies on other systems.
The text was updated successfully, but these errors were encountered:
The worker's top level execute function has a few places where it might potentially throw.
This would result in the worker crashing and all runs in progess getting lost.
This is obviously quite severe but it's not entirely clear what we should do. The worker has an obligation to try and finish all outstanding work and report back to lightnig.
For example: failure to join the run channel will result in an unhandled exception. At this point something is very wrong. I don't think we can report back to Lightning yet because we've not even been able to join the comms channel (or we were kicked out). So the run is probably lost at this point. We should probably kill the whole worker (but give existing runs a chance to finish)
There are probably a few other equally nefarious places where an error will result in the whole worker crashing. It's a very sensitive bit of code with a lot of asyncrhonicity and dependencies on other systems.
The text was updated successfully, but these errors were encountered: