Skip to content

Conversation

@mikemhenry
Copy link
Contributor

First pass on a script to QA using our RelativeHybridTopologyProtocol

Checklist

  • Added a news entry

Developers certificate of origin

@github-actions
Copy link

No API break detected ✅

@mikemhenry
Copy link
Contributor Author

@IAlibay let me know if you have any feedback, I think pulling down the benchmark repo or using a local copy would be a nice improvement.

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (d2e84ee) to head (fc822c8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
- Coverage   92.79%   92.74%   -0.06%     
==========================================
  Files         141      141              
  Lines       10863    10868       +5     
==========================================
- Hits        10080    10079       -1     
- Misses        783      789       +6     
Flag Coverage Δ
fast-tests 92.74% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay
Copy link
Member

IAlibay commented May 27, 2025

🤔 This might be worth discussing, I'm wondering if this is the right place for this to exist.

Ideally we would want to have this in a place where we can also store results. We still need to clean up openfe-benchmarks, but maybe there?

To explain what I'm thinking a bit more, I can see this becoming a thing that grows to be more automated over time, especially if you do things like pulling down the benchmark repo automatically etc... and so maybe it should be somewhere we can test it etc..

@mikemhenry
Copy link
Contributor Author

I agree, I think it needs to live somewhere, my thoughts putting it here is it isn't shipped with the package and isn't in a very public place, I worry about putting it in the benchmark repo right now since it doesn't have a ton of visibility, I do think it should get tested, happy to put it somewhere else!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants