-
Notifications
You must be signed in to change notification settings - Fork 34
vendor perses atom mapper #1637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
pre-commit.ci autofix |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
==========================================
- Coverage 95.34% 88.82% -6.52%
==========================================
Files 183 184 +1
Lines 15779 16422 +643
==========================================
- Hits 15044 14587 -457
- Misses 735 1835 +1100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly veto this addition, we can discuss when I'm back next week.
…atom-mapper' into feat/vendor-perses-atom-mapper
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
No API break detected ✅ |
The main motivation of this PR is that
persesis not really maintained upstream.Really the only part of
perseswe (optionally) use is the atom mapper and scorer.This part of the code has no new deps, which means that you can use the
persesatom mapper and scorer without installingperses(which brings in many unneeded deps).Fixes #1635
Checklist
newsentryDevelopers certificate of origin