From 2064440e4fae2c34a2829c3be19e0208ad568b36 Mon Sep 17 00:00:00 2001 From: Kuingsmile <96409857+Kuingsmile@users.noreply.github.com> Date: Thu, 8 Jan 2026 15:53:33 +0800 Subject: [PATCH] fix duplication accuracy level calculations logic bug --- src/duplicate.cpp | 6 +++--- src/main.cpp | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/duplicate.cpp b/src/duplicate.cpp index eecba8e1..7c37d845 100644 --- a/src/duplicate.cpp +++ b/src/duplicate.cpp @@ -19,7 +19,7 @@ Duplicate::Duplicate(Options* opt) { // level 3: 4G // level 4: 8G // level 5: 16G - // level 6: 24G + // level 6: 32G switch(mOptions->duplicate.accuracyLevel) { case 1: break; @@ -40,7 +40,7 @@ Duplicate::Duplicate(Options* opt) { break; case 6: mBufLenInBytes *= 8; - mBufNum *= 3; + mBufNum *= 4; break; default: break; @@ -161,7 +161,7 @@ bool Duplicate::applyBloomFilter(uint64* positions) { //isDup = isDup && (mDupBuf[i * mBufLenInBytes + bytePos] & byte); uint8 ret = atomic_fetch_or(mDupBuf + i * mBufLenInBytes + bytePos, byte); - isDup = (ret & byte) != 0; + isDup &= (ret & byte) != 0; } return isDup; } diff --git a/src/main.cpp b/src/main.cpp index 422c8d18..db9566ec 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -70,7 +70,7 @@ int main(int argc, char* argv[]){ // duplication evaluation and deduplication cmd.add("dedup", 'D', "enable deduplication to drop the duplicated reads/pairs"); - cmd.add("dup_calc_accuracy", 0, "accuracy level to calculate duplication (1~6), higher level uses more memory (1G, 2G, 4G, 8G, 16G, 24G). Default 1 for no-dedup mode, and 3 for dedup mode.", false); + cmd.add("dup_calc_accuracy", 0, "accuracy level to calculate duplication (1~6), higher level uses more memory (1G, 2G, 4G, 8G, 16G, 32G). Default 1 for no-dedup mode, and 3 for dedup mode.", false); cmd.add("dont_eval_duplication", 0, "don't evaluate duplication rate to save time and use less memory."); // polyG tail trimming