Skip to content

Commit 9adf3f3

Browse files
committed
#16 Add options to choose either a self-signed or CA-signed signing certificate
- To disable signing altogether the `disableSigning` property should be set to `true`. This can be done by appending `-DdisableSigning=true` to the `ant` command - To sign with the bundled self-signed certificate, no additional properties need to be set - To sign with a CA signing certificate, append `-Dcert=ca` and `Dkeystore_property_file=/path/to/keystore.properties` Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
1 parent 4973e86 commit 9adf3f3

File tree

1 file changed

+74
-17
lines changed

1 file changed

+74
-17
lines changed

server/build.xml

Lines changed: 74 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1062,23 +1062,80 @@
10621062
</sequential>
10631063
</for>
10641064

1065-
<!-- sign jars for webstart -->
1066-
<echo message="[Thread Count: ${signjar_thread_count}] Signing jars for Java Web Start" />
1067-
<property file="${keystore_property_file}" />
1068-
1069-
<for param="jarFile" parallel="true" threadCount="${signjar_thread_count}">
1070-
<fileset dir="${setup.client.lib}" includes="**/*.jar" />
1071-
<fileset dir="${setup.extensions}" includes="**/*.jar" />
1072-
<sequential>
1073-
<retry retrycount="5" retrydelay="1000">
1074-
<signjar jar="@{jarFile}" alias="${key.alias}" keystore="${key.keystore}" storepass="${key.storepass}" keypass="${key.keypass}" storetype="${key.storetype}" tsaurl="http://timestamp.digicert.com" digestalg="SHA-256">
1075-
<!-- http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127374 -->
1076-
<sysproperty key="jsse.enableSNIExtension" value="false" />
1077-
<sysproperty key="https.protocols" value="TLSv1.2,TLSv1.1" />
1078-
</signjar>
1079-
</retry>
1080-
</sequential>
1081-
</for>
1065+
1066+
<if>
1067+
<equals arg1="${disableSigning}" arg2="true" />
1068+
1069+
<then>
1070+
<echo message="Signing jars for Java Web Start is disabled" />
1071+
</then>
1072+
1073+
<else>
1074+
<property file="${keystore_property_file}" />
1075+
<property name="signingTsa" value="http://timestamp.digicert.com" />
1076+
1077+
<echo message="[Thread Count: ${signjar_thread_count}] Signing jars for Java Web Start" />
1078+
1079+
<if>
1080+
<equals arg1="${cert}" arg2="ca" />
1081+
1082+
<!-- Sign jars with valid CA certificate -->
1083+
<then>
1084+
<echo message="Signing with CA certificate" />
1085+
1086+
<for param="jarFile" parallel="true" threadCount="${signjar_thread_count}">
1087+
<fileset dir="${setup.client.lib}" includes="**/*.jar" />
1088+
<fileset dir="${setup.extensions}" includes="**/*.jar" />
1089+
<sequential>
1090+
<retry retrycount="5" retrydelay="1000">
1091+
<signjar
1092+
jar="@{jarFile}"
1093+
alias="${key.alias}"
1094+
storepass="${key.storepass}"
1095+
storetype="${key.storetype}"
1096+
providerclass="${key.providerclass}"
1097+
providerarg="${key.providerarg}"
1098+
tsaurl="${signingTsa}"
1099+
>
1100+
<!-- http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127374 -->
1101+
<sysproperty key="jsse.enableSNIExtension" value="false" />
1102+
<sysproperty key="https.protocols" value="TLSv1.2,TLSv1.1" />
1103+
</signjar>
1104+
</retry>
1105+
</sequential>
1106+
</for>
1107+
</then>
1108+
1109+
<!-- Sign jars with self-signed certificate -->
1110+
<else>
1111+
<echo message="Signing with self-signed certificate" />
1112+
1113+
<for param="jarFile" parallel="true" threadCount="${signjar_thread_count}">
1114+
<fileset dir="${setup.client.lib}" includes="**/*.jar" />
1115+
<fileset dir="${setup.extensions}" includes="**/*.jar" />
1116+
<sequential>
1117+
<retry retrycount="5" retrydelay="1000">
1118+
<signjar
1119+
jar="@{jarFile}"
1120+
alias="${key.alias}"
1121+
keystore="${key.keystore}"
1122+
storepass="${key.storepass}"
1123+
keypass="${key.keypass}"
1124+
storetype="${key.storetype}"
1125+
tsaurl="${signingTsa}"
1126+
digestalg="SHA-256"
1127+
>
1128+
<!-- http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127374 -->
1129+
<sysproperty key="jsse.enableSNIExtension" value="false" />
1130+
<sysproperty key="https.protocols" value="TLSv1.2,TLSv1.1" />
1131+
</signjar>
1132+
</retry>
1133+
</sequential>
1134+
</for>
1135+
</else>
1136+
</if>
1137+
</else>
1138+
</if>
10821139
</target>
10831140

10841141
<target name="create-extension-zips" depends="create-setup">

0 commit comments

Comments
 (0)