Skip to content

Commit a063f75

Browse files
committed
Improve error messsages for a few sharp edges
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
1 parent db8615f commit a063f75

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

server/src/com/mirth/connect/client/core/Client.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ public Connector getConnector(javax.ws.rs.client.Client client, Configuration ru
196196
try {
197197
config.register(Class.forName(apiProviderClass));
198198
} catch (Throwable t) {
199-
logger.error("Error registering API provider class: " + apiProviderClass);
199+
logger.error("Error registering API provider class: {}", apiProviderClass, t);
200200
}
201201
}
202202
}
@@ -219,7 +219,7 @@ public void registerApiProviders(Set<String> packageNames, Set<String> classes)
219219
client.register(clazz);
220220
}
221221
} catch (Throwable t) {
222-
logger.error("Error registering API provider package: " + packageName);
222+
logger.error("Error registering API provider package: {}", packageName, t);
223223
}
224224
}
225225
}
@@ -229,7 +229,7 @@ public void registerApiProviders(Set<String> packageNames, Set<String> classes)
229229
try {
230230
client.register(Class.forName(clazz));
231231
} catch (Throwable t) {
232-
logger.error("Error registering API provider class: " + clazz);
232+
logger.error("Error registering API provider class: {}", clazz, t);
233233
}
234234
}
235235
}

server/src/com/mirth/connect/server/api/MirthServlet.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,9 @@ private void setContext() {
210210
}
211211

212212
public void setOperation(Operation operation) {
213+
if (operation == null) {
214+
throw new MirthApiException("Method operation cannot be null.");
215+
}
213216
if (extensionName != null) {
214217
operation = new ExtensionOperation(extensionName, operation);
215218
}

0 commit comments

Comments
 (0)