Upgrades commons libraries to fix security vulnerabilities #219
Conversation
Updates several Apache Commons dependencies across modules to newer patch releases to fix security vulnerabilities. Fixes OpenIntegrationEngine#218 Notably upgrades commons-lang3 (3.13.0 → 3.18.0), commons-beanutils (1.9.4 → 1.11.0) and commons-configuration2 (2.8.0 → 2.10.1), replacing old JARs with the updated artifacts. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
There are references that need to be updated in /server/build.xml and /manager/ant-build.xml. Some of these libraries get added to the manifests of the launcher jars. I'm less concerned about /manager since we don't ship that, and it's probably going to be rewritten at some point, but since you are already updating the jars, you should probably update the build file to match.
Also, the /generator project should probably be kept up to date. That doesn't run on every build, but it is what creates https://github.com/OpenIntegrationEngine/engine/blob/main/server/lib/mirth-vocab.jar
I'd want to see the results of some people testing these changes and check if there are any documented compatibility issues with newer versions before we merge.
Updates several bundled library versions referenced in application manifests to newer releases Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Bumps the Commons Lang library Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Done!
Also Done! |
mgaffigan
left a comment
mgaffigan
left a comment
There was a problem hiding this comment.
Old versions referenced in:
- donkey/.classpath
- donkey/lib/commons/commons-beanutils-1.9.4.jar
- donkey/lib/commons/commons-lang3-3.13.0.jar
- command/.classpath
There was a problem hiding this comment.
Why is this removed without replacement?
There was a problem hiding this comment.
Because it was neither in the classpath, nor the build.xml.
There was a problem hiding this comment.
It's included in the build classpath on command/build.xml:5..7
There was a problem hiding this comment.
Ah. I used the search tool to look for explicit mentions as is done in the other build files.
Added the new version.
Bumps several third-party Commons libraries to newer releases Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
3 participants
Updates several Apache Commons dependencies across modules to newer patch releases to fix security vulnerabilities.
Fixes #218
Notably upgrades
commons-lang3 (3.13.0 → 3.18.0),
commons-beanutils (1.9.4 → 1.11.0) and
commons-configuration2 (2.8.0 → 2.10.1), replacing old JARs with the updated artifacts.