Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow developer to input PR number for lsp4ij checkout input #998

Open
TrevCraw opened this issue Oct 1, 2024 · 1 comment · May be fixed by #1014
Open

Allow developer to input PR number for lsp4ij checkout input #998

TrevCraw opened this issue Oct 1, 2024 · 1 comment · May be fixed by #1014
Assignees
@vaisakhkannan
Labels
ci/cd enhancement New feature or request lsp4ij
Milestone
CI/CD Next

Comments

@TrevCraw
Copy link
Contributor

TrevCraw commented Oct 1, 2024

As documented here - https://github.com/OpenLiberty/liberty-tools-intellij/blob/main/docs/LSP4IJ-Continuous-Integration.md#manually-trigger-workflow - developers can input a branch name, a tag, or a commit SHA as input for "Reference/branch for Lsp4ij checkout" for the Build workflow to kick off a build against a specific build of LSP4IJ.

It would be nice if instead of requiring developers to go find a merge commit SHA for a PR, they could just input a PR number and the workflow would be able to find the merge commit SHA for them.
@TrevCraw TrevCraw added enhancement New feature or request ci/cd lsp4ij labels Oct 1, 2024
@TrevCraw TrevCraw added this to the Next milestone Oct 1, 2024
@TrevCraw TrevCraw moved this from New Issues to Prioritized in Open Liberty Developer Experience Oct 1, 2024
@vaisakhkannan vaisakhkannan moved this from Prioritized to In Progress in Open Liberty Developer Experience Oct 3, 2024
@vaisakhkannan
Copy link
Contributor

As part of testing, I found that there may be situations where the merge commit SHA has a null value. This occurs when a developer tries to input the LSP4IJ PR number to run the build.

Screenshot 2024-10-10 at 4 20 08 PM

@vaisakhkannan vaisakhkannan linked a pull request Oct 10, 2024 that will close this issue
Open
@TrevCraw TrevCraw modified the milestones: Next, Next CI/CD Oct 29, 2024
vaisakhkannan added a commit to vaisakhkannan/liberty-tools-intellij that referenced this issue Nov 15, 2024
@vaisakhkannan
Merge pull request #35 from vaisakhkannan/OpenLiberty#998-Allow-input…
0298b5d 
…-LSP4IJ-PR-number

OpenLiberty#998 allow input lsp4 ij pr number
vaisakhkannan added a commit to vaisakhkannan/liberty-tools-intellij that referenced this issue Nov 15, 2024
@vaisakhkannan
Merge pull request #36 from vaisakhkannan/Fix-#998-Allow-input-LSP4IJ…
edb8678 
…-PR-number

Fix OpenLiberty#998 allow input lsp4 ij pr number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaisakhkannan vaisakhkannan

Labels
ci/cd enhancement New feature or request lsp4ij
Projects
Open Liberty Developer Experience
Status: In Progress
Milestone
CI/CD Next
Development

Successfully merging a pull request may close this issue.

Enabled developer to input PR number for lsp4ij checkout input vaisakhkannan/liberty-tools-intellij
2 participants
@TrevCraw @vaisakhkannan