Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to LSP4MP 0.13.0 #1057

Closed
mrglavas opened this issue Oct 29, 2024 · 7 comments
Closed

Upgrade to LSP4MP 0.13.0 #1057

mrglavas opened this issue Oct 29, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request language client language server integration
Milestone

Comments

@mrglavas
Copy link
Contributor

See the change log here: https://github.com/eclipse/lsp4mp/blob/master/CHANGELOG.md. The fix for eclipse/lsp4mp#464 is expected to resolve #1016.

@mrglavas mrglavas self-assigned this Oct 29, 2024
@mrglavas mrglavas added language client language server integration enhancement New feature or request labels Oct 29, 2024
@mrglavas mrglavas moved this from New Issues to In Progress in Open Liberty Developer Experience Oct 29, 2024
@angelozerr
Copy link

Please note that 0.7.0 have a bug that I have fixed in redhat-developer/lsp4ij#580

@mrglavas
Copy link
Contributor Author

@angelozerr Does this mean the problem with completion being offered after the curly brace (#1016) isn't resolved by LSP4iJ 0.7.0?

@angelozerr
Copy link

angelozerr commented Oct 29, 2024

It is fixed. But there is badly a new bug that I have tried to explain.

Sometimes if you have no luck, you loose completion for microprofile-config.properties a very annoying bug that I have fixed and will be available in 0.8.0

@mrglavas mrglavas added this to the Next milestone Oct 29, 2024
@mrglavas
Copy link
Contributor Author

Thanks for clarifying. Our build automation is continuously testing LSP4IJ PRs so hopefully this is getting exercised by our automated tests already.

@mrglavas
Copy link
Contributor Author

@angelozerr I noticed that there are Maven artifacts for LSP4MP 0.13.0, 0.13.1 and 0.13.2. I wasn't sure which of these to use so went with 0.13.0 since I see that is currently being pulled in by Quarkus Tools. Since they all look like they were published on the same day I'm wondering if they're all essentially the same release. Do you know what is going on here? The change log https://github.com/eclipse/lsp4mp/blob/master/CHANGELOG.md only mentions 0.13.0.

@angelozerr
Copy link

@angelozerr I noticed that there are Maven artifacts for LSP4MP 0.13.0, 0.13.1 and 0.13.2. I wasn't sure which of these to use so went with 0.13.0 since I see that is currently being pulled in by Quarkus Tools. Since they all look like they were published on the same day I'm wondering if they're all essentially the same release. Do you know what is going on here? The change log https://github.com/eclipse/lsp4mp/blob/master/CHANGELOG.md only mentions 0.13.0.

We had some trouble when we have created the release with the CI build. 0.13.0, 1 and 2 are the same.

@mrglavas
Copy link
Contributor Author

Resolved by #1058.

@github-project-automation github-project-automation bot moved this from In Progress to Sprint Closed in Open Liberty Developer Experience Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request language client language server integration
Projects
Development

No branches or pull requests

2 participants