Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for developers to understand continuous build integration #990

Merged
merged 12 commits into from
Sep 27, 2024
Merged

Documentation for developers to understand continuous build integration #990

merged 12 commits into from
Sep 27, 2024

Conversation

anusreelakshmi934
Copy link
Contributor

Fixes #896

TrevCraw
TrevCraw requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@TrevCraw TrevCraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! Made some minor suggestions.

I think we should also include a link to the new continuous integration doc from the DEVELOPING.md page.

docs/LSP4IJ-Integration.md Outdated Show resolved Hide resolved
docs/LSP4IJ-Integration.md Outdated Show resolved Hide resolved
docs/LSP4IJ-Integration.md Outdated Show resolved Hide resolved
docs/LSP4IJ-Integration.md Outdated Show resolved Hide resolved
docs/LSP4IJ-Integration.md Outdated Show resolved Hide resolved
docs/LSP4IJ-Integration.md Outdated Show resolved Hide resolved
docs/LSP4IJ-Integration.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
TrevCraw
TrevCraw requested changes Sep 26, 2024
View reviewed changes
DEVELOPING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/LSP4IJ-Integration.md Outdated Show resolved Hide resolved
docs/LSP4IJ-Continuous-Integration.md Outdated Show resolved Hide resolved
docs/LSP4IJ-Continuous-Integration.md Outdated Show resolved Hide resolved
docs/LSP4IJ-Continuous-Integration.md Outdated Show resolved Hide resolved
docs/LSP4IJ-Continuous-Integration.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
mrglavas
mrglavas approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with the team yesterday. Looks good.

@TrevCraw TrevCraw merged commit 1164551 into OpenLiberty:main Sep 27, 2024
1 of 3 checks passed
@TrevCraw TrevCraw mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrglavas mrglavas mrglavas approved these changes

@TrevCraw TrevCraw TrevCraw approved these changes

@turkeylurkey turkeylurkey turkeylurkey approved these changes

@aparnamichael aparnamichael Awaiting requested review from aparnamichael

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for developers to understand continuous build integration
4 participants
@anusreelakshmi934 @mrglavas @TrevCraw @turkeylurkey