Make Object Selection window modal in play mode #3370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And pause the game while it is open, using the same pause flag as browsePrompt window. Fixes OpenLoco#2914 Fixes OpenLoco#3179 Fixes OpenLoco#3369
It appears that it was unnecessary.
As like PromptBrowseWindow (when opened via Game.cpp)
Contributor
Author
|
Known issue: if, with music enabled, you pause the game and then open the object selection window, the music will erroneously resume upon closing the object selection window despite the game still being paused. This is the same issue as #3183. |
| { | ||
| WindowManager::setCurrentModalType(WindowType::objectSelection); | ||
|
|
||
| SceneManager::setPauseFlag(1 << 3); // Pause flag 3 was not used by vanilla. |
Member
There was a problem hiding this comment.
What's the reasoning for pausing the game while this window is open? This isn't necessary for the window to be modal, right.
Contributor
There was a problem hiding this comment.
But it is the source of the bugs
duncanspumpkin
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And pause the game while it is open.
Fixes #2914
Fixes #3179
Fixes #3369