Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whether lr_scheduler for Lomo is implemented now? #93

Open
DesperateExplorer opened this issue Jul 26, 2023 · 4 comments
Open

Whether lr_scheduler for Lomo is implemented now? #93

DesperateExplorer opened this issue Jul 26, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@DesperateExplorer
Copy link

Hi authors,

Whether lr = trainer.lr_scheduler.step(global_step) for Lomo in the Trainer is implemented?

If so, how to enable it?

Thanks!

@DesperateExplorer DesperateExplorer changed the title Whether lr_scheduler for Lomo is executable now? Whether lr_scheduler for Lomo is implemented now? Jul 26, 2023
@KaiLv69
Copy link
Collaborator

KaiLv69 commented Jul 26, 2023

@DesperateExplorer
Copy link
Author

I mean lr_scheduler for Lomo, not AdamW. lr_scheduler for Lomo requires the lr_scheduler.step function to accept a global_step parameter.

@KaiLv69
Copy link
Collaborator

KaiLv69 commented Jul 26, 2023

Sry, and I get you now. This is a bug and we are planning to fix it to align with the api call with PyTorch's lr_scheduler.
Currently, maybe you can pass this lr_scheduler to trainer when training with Lomo.
https://github.com/OpenLMLab/LOMO/blob/24cde8e91feac437809bf7790f4727623dce6a76/src/utils.py#L207

@KaiLv69
Copy link
Collaborator

KaiLv69 commented Jul 31, 2023

Hi, lr_scheduler for LOMO is implemented and mergd into branch:dev now.
FYI:3b69924

@00INDEX 00INDEX added the bug Something isn't working label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants