From 401908df214aa3a91f080974670c7d5f79738b94 Mon Sep 17 00:00:00 2001 From: Sven Reichel Date: Wed, 18 Sep 2024 05:06:01 +0200 Subject: [PATCH] phpstan fix --- .phpstan.dist.baseline.neon | 5 ----- .phpstan.dist.neon | 4 ---- lib/Mage/HTTP/Client/Curl.php | 2 +- 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/.phpstan.dist.baseline.neon b/.phpstan.dist.baseline.neon index 18291848aca..8e50e08bf4f 100644 --- a/.phpstan.dist.baseline.neon +++ b/.phpstan.dist.baseline.neon @@ -4860,11 +4860,6 @@ parameters: count: 1 path: lib/Mage/DB/Mysqli.php - - - message: "#^Property Mage_HTTP_Client_Curl\\:\\:\\$_ch \\(object\\) does not accept resource\\.$#" - count: 1 - path: lib/Mage/HTTP/Client/Curl.php - - message: "#^Property Mage_HTTP_Client_Socket\\:\\:\\$_postFields is never read, only written\\.$#" count: 1 diff --git a/.phpstan.dist.neon b/.phpstan.dist.neon index 77ead18bbde..d56b4f77325 100644 --- a/.phpstan.dist.neon +++ b/.phpstan.dist.neon @@ -69,9 +69,5 @@ parameters: checkFunctionNameCase: true checkInternalClassCaseSensitivity: true treatPhpDocTypesAsCertain: false - # For v1.12+ with "bleeding edge" - ignoreErrors: - - - identifier: missingType.iterableValue # universalObjectCratesClasses: # - Varien_Object diff --git a/lib/Mage/HTTP/Client/Curl.php b/lib/Mage/HTTP/Client/Curl.php index 6ec2afba3ea..4fab8a3ac51 100644 --- a/lib/Mage/HTTP/Client/Curl.php +++ b/lib/Mage/HTTP/Client/Curl.php @@ -89,7 +89,7 @@ class Mage_HTTP_Client_Curl implements Mage_HTTP_IClient /** * Curl - * @var object + * @var false|resource */ protected $_ch;