v19.4.18

[fballiano]

Overview

This is a bugfix release while we're working on completing the full PHPStan validation, which is allowing us to reformat the whole source code to make it look more beautiful than ever.

Last but not least, we already merged 2 PRs for the upcoming PHP 8.2 support!

Important things you should check before upgrading

• Added weight for API salesOrderShipmentAddTrack by @luigifab in Add weight for API salesOrderShipmentAddTrack #1377
• Color swatches work with disparate product IDs by @luigifab in Color swatches work with disparate product IDs #2390
• Changed default root dir (composer install) by @sreichel in Change default root dir (composer install) #2401
• Fixed targetNamespace in WS-I Compliant by @leissbua in Fix targetNamespace in WS-I Compliant #2405
• Removed unused boxover.js by @fballiano in Removed unused boxover.js #2435
• Fixed "Is Required" custom option attribute always set "Yes" in PHP8.1 by @fballiano in Fixed "Is Required" custom option attribute always set "Yes" in PHP8.1 #2441
• Removed unused jQuery 1.10.2, updated jQuery 1.12.1 to 1.12.4 by @fballiano in Removed unused jQuery 1.10.2, updated jQuery 1.12.1 to 1.12.4 #2442
• Removed hideit input field from Contact form by @addison74 in Remove hideit input field from Contact form #2398
• Split Mage_All.xml into own module XML files by @tmewes in Split Mage_All.xml into own module XML files #2455
• Updated jQuery Cycle for rwd theme by @fballiano in Updated jQuery Cycle for rwd theme #2505

Complete changelog

• Use constant for _isAllowed() check by @sreichel in Use constant for _isAllowed() check #2342
• Revert "Add basic text for Ukraine (Add a message calling for an end to the Russian invasion of Ukraine #2074)" by @fballiano in Revert "Add basic text for Ukraine (#2074)" #2325
• Mage_Catalog_Model_Product_Attribute_Backend_Groupprice_Abstract: avoid loading all websites when using only the current one by @fballiano in Mage_Catalog_Model_Product_Attribute_Backend_Groupprice_Abstract: avoid loading all websites when using only the current one #2351
• Make Curl Client HTTP/2 compatible by @Schrank in Make Curl Client HTTP/2 compatible #1137
• Block access to all dot files. by @colinmollenhour in Block access to all dot files. #2349
• Capitalization Adjustment Regarding CamelCase in Method Names by @Sdfendor in Capitalization Adjustment Regarding CamelCase in Method Names #2365
• Some microoptimization by @sreichel in Some microoptimization #2335
• Enclosed error with <pre> tag for prettier error print. by @kiatng in Enclosed error with <pre> tag for prettier error print. #2368
• Updated phpstan to 1.8.2 by @sreichel in Updated phpstan to 1.8.2 #2367
• Escape product titles in MSRP JavaScript by @discountscott in Escape product titles in MSRP JavaScript #2366
• Backend grid heads - Align the elements for range and date types by @addison74 in Backend grid heads - Align the elements for range and date types #2330
• Force describeTable() to use read DB adapter by @fballiano in Force describeTable() to use read DB adapter #2371
• Do not install n98/n98_layouthelper by @sreichel in Do not install n98/n98_layouthelper #2373
• Replaced deprecated method getRegionJson() with getRegionJsonByStore(). by @kiatng in Replaced deprecated method getRegionJson() with getRegionJsonByStore(). #2375
• Replaced remaining sizeof alias calls by @Sdfendor in Replace Remaining sizeof Alias Calls  #2369
• Removed DISCLAIMER and change Magento -> OpenMage in header by @justinbeaty in Remove DISCLAIMER and change Magento -> OpenMage in header #2297
• Added label for phpstan cosmetic changes by @sreichel in Add label for phpstan cosmetic changes #2384
• Added weight for API salesOrderShipmentAddTrack by @luigifab in Add weight for API salesOrderShipmentAddTrack #1377
• PHPStan/DOCBlock fixes ... by @sreichel in PHPStan/DOCBlock fixes ... #2336
• Updated docs for email addTo() by @sreichel in Updated docs for email addTo() #2382
• Updated phpstan experimental by @sreichel in Updated phpstan experimental #2386
• Cosmetic changes to Mage_Payment_Model_Method_Abstract::validate() by @fballiano in Cosmetic changes to Mage_Payment_Model_Method_Abstract::validate() #2388
• Replaced Remaining join Alias Calls by @Sdfendor in Replace Remaining join Alias Calls  #2389
• Hidden empty sub menu by @luigifab in Hide empty sub menu #2391
• Removed Thumbs.db file by @luigifab in Remove Thumbs.db file #2394
• Fixed Issue with PHP < 8.1 in composer.json by @addison74 in Issue with PHP < 8.1 in composer.json #2378
• Blocked access to various project files by @colinmollenhour in Block access to various project files #2359
• Color swatches work with disparate product IDs by @luigifab in Color swatches work with disparate product IDs #2390
• Moved Credit Memo button at the end by @luigifab in Move Credit Memo button at the end #2392
• Minor fixes on 'filter_condition_callback' method _filterStoreConditi… by @kiatng in Minor fixes on 'filter_condition_callback' method _filterStoreConditi… #2362
• Added ReturnTypeWillChange to various Files catched by code style checker by @Flyingmana in add ReturnTypeWillChange to various Files catched by code style checker #2302
• Phpstan fixes by @sreichel in Phpstan fixes #2396
• Fixed camelCase in lib/Varien by @sreichel in Fixed camelCase in lib/Varien #2403
• Changed default root dir (composer install) by @sreichel in Change default root dir (composer install) #2401
• Fixed targetNamespace in WS-I Compliant by @leissbua in Fix targetNamespace in WS-I Compliant #2405
• Removed deprecated string interpolation for PHP 8.2 by @fballiano in Removed deprecated string interpolation for PHP 8.2 #2408
• Moved files out of root by @sreichel in Moved files out of root #2414
• Product reviews backend: fixed grid ID typo preventing save button to show by @fballiano in Product reviews backend: fixed grid ID typo preventing save button to show #2415
• Added ReturnTypeWillChange to Varien_Data_Collection by @Sdfendor in Add ReturnTypeWillChange to Varien_Data_Collection #2409
• Added null check before method_exists by @holozaen in Add null check before method_exists #2417
• Removed deprecated utf8_encode() for PHP 8.2 by @fballiano in Remove deprecated utf8_encode() for PHP 8.2 #2404
• Method Annotation Improvement Mage_Catalog_Model_Product_Option_Type_Date by @Sdfendor in Method Annotation Improvement Mage_Catalog_Model_Product_Option_Type_Date  #2418
• Correct usage for adding items to ArrayObject by @sreichel in Correct usage for adding items to ArrayObject #2372
• Removed useless array_column function polyfill by @elidrissidev in Remove useless array_column function polyfill #2423
• Fixed wishlist share email validation by @sreichel in Fix wishlist share email validation #2425
• Small improvements to openmage backend theme for better readability by @fballiano in Small improvements to openmage backend theme for better readability #2257
• Comments More Typo Fixes Retreive => Retrieve by @Sdfendor in Comments More Typo Fixes Retreive => Retrieve #2431
• Removed unused boxover.js by @fballiano in Removed unused boxover.js #2435
• phpstan: fixed calls to Mage_Core_Block_Abstract by @sreichel in phpstan: fixed calls to Mage_Core_Block_Abstract #2412
• Added some dev tools & code sniffers by @sreichel in Added some dev tools & code sniffers #2400
• Updated phstorm meta files by @sreichel in Updated phstorm meta files #2436
• Added "number" validation to minimum order amount in the backend by @fballiano in Added "number" validation to minimum order amount in the backend #2439
• DHL International: PHP8: Cast $dimension before calling round() by @fballiano in DHL International: PHP8: Cast $dimension before calling round() #2438
• [backport] Added a configuration flag to disable global search in adminhtml by @sreichel in [backport] Added a configuration flag to disable global search in adminhtml #2443
• Fixed "Is Required" custom option attribute always set "Yes" in PHP8.1 by @fballiano in Fixed "Is Required" custom option attribute always set "Yes" in PHP8.1 #2441
• Fixed wrong setDefaultSort() with two parameters by @sreichel in Fixed wrong setDefaultSort() with two parameters #2446
• Fixed wrong camelCase by @sreichel in Fixed wrong camelCase #2452
• phpstan: fixed call to an undefined method Mage_Core_Helper_Abstract::init() by @sreichel in phpstan: fixed call to an undefined method Mage_Core_Helper_Abstract::init() #2453
• Fixed yoda style by @sreichel in Fixed yoda style #2459
• Use short array syntax by @sreichel in Use short array syntax #2458
• Removed meaningless "enter description here" comments in code by @fballiano in Removed meaningless "enter description here" comments in code #2463
• Removed unused constant GALLERY_IMAGE_TABLE by @fballiano in Removed unused constant GALLERY_IMAGE_TABLE #2460
• Fixed yoda style & short array syntax in app\Mage.php by @sreichel in Fixed yoda style & short array syntax in app\Mage.php #2465
• Fixed sort direction by @sreichel in Fixed sort direction #2468
• Removed deprecated class Mage_Tag_Block_Customer_Edit by @fballiano in Removed deprecated class Mage_Tag_Block_Customer_Edit #2462
• Use composer-plugin to install phpcs sniffs by @sreichel in Use composer-plugin to install phpcs sniffs #2470
• Added loading delay adminhtml by @justinbeaty in Add loading delay adminhtml #2426
• Fixed some email template resources by @justinbeaty in Fix some email template resources #2476
• Phpstan fixes by @sreichel in Phpstan fixes #2457
• Fixed default sort order for admin catalog search terms, closes Backend > Search Term - Add ID column #2477 by @sreichel in Fixed default sort order for admin catalog search terms, closes #2477 #2480
• Cosmetic changes to backend footer by @fballiano in Cosmetic changes to backend footer #2482
• Addendum to Add loading delay adminhtml #2426 - Adminhtml loader by @justinbeaty in Addendum to #2426 - Adminhtml loader #2475
• Removed memory_limit checks for better performance by @fballiano in Removed memory_limit checks for better performance #2471
• Fixed typos for "deprecated" word by @fballiano in Fixed typos for "deprecated" word #2487
• phpstan: fixed calls to Mage_Core_Abstract_Helper by @sreichel in phpstan: fixed calls to Mage_Core_Abstract_Helper #2483
• Fixed lowercase for constants true/false/null by @fballiano in Fixed lowercase for constants true/false/null #2489
• Removed useless returns by @fballiano in Removed useless returns #2488
• Removed useless variables for return statements by @sreichel in Removed useless variables for return statements #1397
• Removed extra blank lines by @fballiano in Removed extra blank lines #2490
• Removed deprecation notice for Mage_Catalog_Model_Resource_Product_Attribute_Backend_Urlkey by @fballiano in Removed deprecation notice for Mage_Catalog_Model_Resource_Product_Attribute_Backend_Urlkey #2461
• Removed unused jQuery 1.10.2, updated jQuery 1.12.1 to 1.12.4 by @fballiano in Removed unused jQuery 1.10.2, updated jQuery 1.12.1 to 1.12.4 #2442
• Fixed bug on mini login form. by @kiatng in Fixed bug on mini login form. #2377
• Removed hideit input field from Contact form by @addison74 in Remove hideit input field from Contact form #2398
• Updated README with Redis 7 by @fballiano in Updated README with Redis 7 #2491
• Split Mage_All.xml into own module XML files by @tmewes in Split Mage_All.xml into own module XML files #2455
• Removed note about old (unexisting) branches from README by @fballiano in Removed note about old (unexisting) branches from README #2495
• Better wording for adminhtml footer by @fballiano in Better wording for adminhtml footer #2486
• phpstan: Fixed calls to Mage_Core_Model_Resource_Helper_Abstract by @sreichel in phpstan: Fixed calls to Mage_Core_Model_Resource_Helper_Abstract #2494
• Removed unused fastclick.js by @fballiano in Removed unused fastclick.js #2503
• Hotfix sorting be entity ID by @sreichel in Hotfix sorting be entity ID #2509
• Removed deprecated setLanguageCode javascript function by @fballiano in Removed deprecated setLanguageCode javascript function #2472
• Updated phpdocs for Mage::log() by @sreichel in Updated phpdocs for Mage::log() #2512
• phpstan: fixed unknown types by @sreichel in phpstan: fixed unknown types #2500
• Fixed "should return true but returns false" by @sreichel in Fixed "should return true but returns false" #2513
• Fixed whitespace in docblock for Mage_Adminhtml by @fballiano in Fixed whitespace in docblock for Mage_Adminhtml #2514
• Removed useless constructors by @fballiano in Removed useless constructors #2515
• Fixed MySql4 classes in phpdoc properties/return by @sreichel in Fixed MySql4 classes in phpdoc properties/return #2516
• Error_Processor Refactoring by @Sdfendor in Error_Processor Refactoring #2407
• Removed deprecated code from Mage_Rss by @fballiano in Removed deprecated code from Mage_Rss #2508
• Deprecate PayPal logo block by @fballiano in Deprecate PayPal logo block #2498
• Removed border-top from .block-title class (rwd theme) by @fballiano in Removed border-top from .block-title class (rwd theme) #2507
• Added docs for multistore error pages by @sreichel in Added docs for multistore error pages #2517
• Removed useless constructors by @fballiano in Removed useless constructors #2520
• Removed resource model wrapper by @sreichel in Removed resource model wrapper #2510
• Fixed whitespace for docblocks in modules (Mage_A*, Mage_B*) by @fballiano in Fixed whitespace for docblocks in modules (Mage_A*, Mage_B*) #2522
• Fixed whitespace for docblocks in modules (Mage_C* -> Mage_I*) by @fballiano in Fixed whitespace for docblocks in modules (Mage_C* -> Mage_I*) #2523
• Show product collection limiter only if makes sense by @fballiano in Show product collection limiter only if makes sense #2502
• Fixed whitespace for docblocks in modules (Mage_L* -> Mage_P*) by @fballiano in Fixed whitespace for docblocks in modules (Mage_L* -> Mage_P*) #2525
• Implement the possibility to search for null in backend grids by @digitalpianism in Implement the possibility to search for null in backend grids #1203
• Fixed whitespace for docblocks by @fballiano in Fixed whitespace for docblocks #2528
• Avoid getting lock on frontend for flat catalog indexes by @fballiano in Avoid getting lock on frontend for flat catalog indexes #2492
• Fixed whitespace for docblocks by @fballiano in Fixed whitespace for docblocks #2530
• Replaced Mysql4 class names by @sreichel in Replaced Mysql4 class names #2526
• phpstan: fixes for Varien_Data_Collection by @sreichel in phpstan: fixes for Varien_Data_Collection #2524
• Updated phpdocs, ref phpstan: fixes for Varien_Data_Collection #2524 by @sreichel in Updated phpdocs, ref #2524 #2534
• Added info about Mage_PageCache removal to README by @fballiano in Added info about Mage_PageCache removal to README #2531
• Do not startEnvironmentEmulation for current store by @luigifab in Do not startEnvironmentEmulation for current store #1578
• Updated validation for modelName in Mage_Shipping_Model_Config::_getCarrier() and Mage_Payment_Model_Config::_getMethod() by @eneiasramos in Updated validation for modelName in Mage_Shipping_Model_Config::_getCarrier() and Mage_Payment_Model_Config::_getMethod() #2424
• Fixed whitespace for docblocks by @fballiano in Fixed whitespace for docblocks #2535
• Fixed README with information that was only on branch 20.0 by @fballiano in Fixed README with information that was only on branch 20.0 #2536
• Fixed admin grid filter by @sreichel in Fixed admin grid filter #2537
• Bugfix to avoid newline character \n in customFormSubmit URL by @eneiasramos in Bugfix to avoid newline character \n in customFormSubmit URL #2518
• phpstan: fixed some unknown types by @sreichel in phpstan: fixed some unknown types #2538
• Updated phpstan to 1.8.3 by @sreichel in Update phpstan to 1.8.3 #2540
• Updated jQuery Cycle for rwd theme by @fballiano in Updated jQuery Cycle for rwd theme #2505
• Fixed whitespace for docblocks by @fballiano in Fixed whitespace for docblocks #2542
• Fixed broken grids caused by PR Something broken? #2545 by @fballiano in Fixed broken grids caused by PR #2545 #2546

New Contributors

• @discountscott made their first contribution in Escape product titles in MSRP JavaScript #2366
• @leissbua made their first contribution in Fix targetNamespace in WS-I Compliant #2405

Full Changelog: v19.4.17...v19.4.18

---

This discussion was created from the release v19.4.18.