Null deprecation in mail

[kiatng]

I have this error in the log:

    [type] => 8192:E_DEPRECATED
    [message] => strtr(): Passing null to parameter #1 ($string) of type string is deprecated
    [file] => .../vendor/shardj/zf1-future/library/Zend/Mail.php
    [line] => 1223

Probably from

magento-lts/app/code/core/Mage/Sales/Model/Order/Invoice.php

Line 780 in a42a85b

public function sendEmail($notifyCustomer = true, $comment = '')

Preconditions (*)

1. PHP8

Steps to reproduce (*)

1. Not sure how

Expected result (*)

1. [Screenshots, logs or description]

Actual result (*)

1. [Screenshots, logs or description]

[fballiano]

did it happen again? do you have more info like a backtrace?

[sreichel]

https://github.com/OpenMage/magento-lts/actions/runs/10707689462/job/29688504497

Found sameerror during unit tests. At the moment there is only one method covered that send mails ... seems it comes from sendPasswordResetConfirmationEmail()

[kiatng]

Copy paste for easy ref:

Run php -f vendor/bin/phpunit
PHPUnit [9](https://github.com/OpenMage/magento-lts/actions/runs/10707689462/job/29688504497#step:12:10).6.19 by Sebastian Bergmann and contributors.

PHP Deprecated:  strtr(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/magento-lts/magento-lts/vendor/shardj/zf1-future/library/Zend/Mail.php on line 1223
sh: 1: /usr/sbin/sendmail: not found
...............................................................  63 / 144 ( 43%)
............................................................... 126 / 144 ( 87%)
PHP Deprecated:  str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in /home/runner/work/magento-lts/magento-lts/lib/Varien/Object.php on line 594
..................                                              144 / 144 ([10](https://github.com/OpenMage/magento-lts/actions/runs/10707689462/job/29688504497#step:12:11)0%)

Time: 00:01.529, Memory: 46.00 MB

OK (144 tests, 223 assertions)

Generating code coverage report in Clover XML format ... done [00:30.181]

Generating code coverage report in Crap4J XML format ... done [00:00.549]

[sreichel]

It's not the same ... your report was about 1st parameter, phpunits about 2nd ...