Skip to content

Commit a8a2238

Browse files
authored
Merge pull request #5611 from martin-frbg/issue5602
Fix too small DGEMM_R for some Loongson LA464 cpus
2 parents 8870cfc + 67c0675 commit a8a2238

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

docs/faq.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ You can find the full list of modifications in Changelog.txt.
4747
The detailed explanation is probably in the original publication authored by Kazushige Goto - Goto, Kazushige; van de Geijn, Robert A; Anatomy of high-performance matrix multiplication. ACM Transactions on Mathematical Software (TOMS). Volume 34 Issue 3, May 2008
4848
While this article is paywalled and too old for preprints to be available on arxiv.org, more recent
4949
publications like https://arxiv.org/pdf/1609.00076 contain at least a brief description of the algorithm.
50-
In practice, the values are derived by experimentation to yield the block sizes that give the highest performance. A general rule of thumb for selecting a starting point seems to be that PxQ is about half the size of L2 cache.
50+
In practice, the values are derived by experimentation to yield the block sizes that give the highest performance. A general rule of thumb for selecting a starting point seems to be that PxQ is about half the size of L2 cache. R needs to be greater than the bigger of P and Q by
51+
at least 64, or bad things will happen with the work splitting in (at least) POTRF.
5152

5253
### <a name="reportbug"></a>How can I report a bug?
5354

kernel/setparam-ref.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1194,7 +1194,7 @@ static void init_parameter(void) {
11941194

11951195
TABLE_NAME.dgemm_p = 112;
11961196
TABLE_NAME.dgemm_q = 289;
1197-
TABLE_NAME.dgemm_r = 342;
1197+
TABLE_NAME.dgemm_r = 353;
11981198

11991199
TABLE_NAME.cgemm_p = 128;
12001200
TABLE_NAME.cgemm_q = 256;

0 commit comments

Comments
 (0)