Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise test coverage to 80% or 95% #21

Open
jvmncs opened this issue Oct 11, 2019 · 2 comments
Open

Raise test coverage to 80% or 95% #21

jvmncs opened this issue Oct 11, 2019 · 2 comments
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined!

Comments

@jvmncs
Copy link
Contributor

jvmncs commented Oct 11, 2019

This line should look more like this line and this one.

@jvmncs jvmncs added the Good first issue 🎓 Perfect for beginners, welcome to OpenMined! label Oct 11, 2019
@mrunderline
Copy link

did you really want to replace just 0 with 95?!

@jvmncs
Copy link
Contributor Author

jvmncs commented Oct 11, 2019

There's a bit more to it than that :)

Running the coverage will show that some files are causing test coverage to be below 70%. This issue also requires adding tests to bring coverage up to 80 or 95% (or even 100%)! If you'd like, you can check the coverage yourself with the commands linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined!
Projects
None yet
Development

No branches or pull requests

2 participants