Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Text2MotionDataset loads cached files (in tmp folder), length_list (self.length_arr) is not properly recreated. #103

Open
xaiseung opened this issue Aug 7, 2024 · 0 comments

Comments

@xaiseung
Copy link

xaiseung commented Aug 7, 2024

In mGPT/data/humanml/dataset_t2m.py, line 65~85:

new_name_list = []
length_list = []
data_dict = {}

# Fast loading
...
    with open(...) as file:
        name_list = pickle.load(file)
    for name in new_name_list:
        length_list.append(data_dict[name]['length'])

The cached list of names is stored as name_list, but in line 84, new_name_list (an empty list) is used.
This causes a problem where selt.reset_max_len() does not work as intended.

proposed fix

This can be resolve by:

    for name in name_list:
        length_list.append(data_dict[name]['length'])

I know the original code is from here, but the caching part seems to be added separetely, so I'm issuing this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant