Add unit tests for UUID helper

Author: Sporiff

src/main/java/org/openpodcastapi/opa/helpers/UUIDHelper.java

@@ -22,7 +22,22 @@ private UUIDHelper() {
     /// @param feedUrl the URL to sanitize
     /// @return the sanitized URL
     public static String sanitizeFeedUrl(String feedUrl) {
-        return feedUrl.replaceFirst("^[a-zA-Z]+://", "").replaceAll("/+$", "");
+        if (feedUrl == null || feedUrl.isBlank()) {
+            throw new IllegalArgumentException("Invalid feed URL passed to function");
+        }
+
+        // Reject unsupported schemes (e.g., ftp://)
+        if (feedUrl.matches("^[a-zA-Z]+://.*") && !feedUrl.startsWith("http://") && !feedUrl.startsWith("https://")) {
+            throw new IllegalArgumentException("Invalid feed URL passed to function");
+        }
+
+        String sanitized = feedUrl.replaceFirst("^(https?://)", "").replaceAll("/+$", "");
+
+        if (!sanitized.contains(".")) {
+            throw new IllegalArgumentException("Invalid feed URL passed to function");
+        }
+
+        return sanitized;
     }
 
     /// Calculates the UUID of a provided feed URL using Podcast index methodology.
@@ -34,8 +49,7 @@ public static String sanitizeFeedUrl(String feedUrl) {
     /// @return the calculated UUID
     public static UUID getFeedUUID(String feedUrl) {
         final String sanitizedFeedUrl = sanitizeFeedUrl(feedUrl);
-        final UUID feedUUID = UUID.fromString(sanitizedFeedUrl);
-        return generator.generate(feedUUID.toString());
+        return generator.generate(sanitizedFeedUrl);
     }
 
     /// Validates that a supplied subscription UUID has been calculated properly

src/test/java/org/openpodcastapi/opa/helpers/UUIDHelperTest.java

@@ -0,0 +1,88 @@
+package org.openpodcastapi.opa.helpers;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.UUID;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.openpodcastapi.opa.helpers.UUIDHelper.*;
+
+class UUIDHelperTest {
+    @Test
+    void sanitizeFeedUrl_shouldSanitizeValidUrl() {
+        final String feedUrl = "https://test.com/feed1/";
+        final String expectedUrl = "test.com/feed1";
+        String cleanedUrl = sanitizeFeedUrl(feedUrl);
+
+        assertEquals(expectedUrl, cleanedUrl);
+    }
+
+    @Test
+    void sanitizeFeedUrl_shouldSanitizeUrlWithoutScheme() {
+        final String feedUrl = "test.com/feed1";
+        final String expectedUrl = "test.com/feed1";
+        String cleanedUrl = sanitizeFeedUrl(feedUrl);
+
+        assertEquals(expectedUrl, cleanedUrl);
+    }
+
+    @Test
+    void sanitizeFeedUrl_shouldThrowOnInvalidUrl() {
+        final String feedUrl = "ftp://test.com/feed1";
+        final String expectedMessage = "Invalid feed URL passed to function";
+
+        IllegalArgumentException exception = assertThrows(IllegalArgumentException.class, () -> sanitizeFeedUrl(feedUrl));
+
+        assertTrue(exception.getMessage().contains(expectedMessage));
+    }
+
+    @Test
+    void getFeedUUID_shouldReturnGeneratedUUID() {
+        final String feedUrl = "podnews.net/rss";
+        final UUID expectedUUID = UUID.fromString("9b024349-ccf0-5f69-a609-6b82873eab3c");
+
+        UUID calculatedUUID = getFeedUUID(feedUrl);
+
+        assertEquals(expectedUUID, calculatedUUID);
+    }
+
+    @Test
+    void getFeedUUID_shouldReturnDeterministicUUID() {
+        final String feedUrl = "podnews.net/rss";
+        final UUID incorrectUUID = UUID.fromString("d5d5520d-81da-474e-928b-5fa66233a1ac");
+
+        UUID calculatedUUID = getFeedUUID(feedUrl);
+
+        assertNotEquals(incorrectUUID, calculatedUUID);
+    }
+
+    @Test
+    void validateSubscriptionUUID_shouldReturnTrueWhenValid() {
+        final String feedUrl = "podnews.net/rss";
+        final UUID expectedUUID = UUID.fromString("9b024349-ccf0-5f69-a609-6b82873eab3c");
+
+        assertTrue(validateSubscriptionUUID(feedUrl, expectedUUID));
+    }
+
+    @Test
+    void validateSubscriptionUUID_shouldReturnFalseWhenInvalid() {
+        final String feedUrl = "podnews.net/rss";
+        final UUID incorrectUUID = UUID.fromString("d5d5520d-81da-474e-928b-5fa66233a1ac");
+
+        assertFalse(validateSubscriptionUUID(feedUrl, incorrectUUID));
+    }
+
+    @Test
+    void validateUUIDString_shouldReturnTrueWhenValid() {
+        final String validUUID = "d5d5520d-81da-474e-928b-5fa66233a1ac";
+
+        assertTrue(validateUUIDString(validUUID));
+    }
+
+    @Test
+    void validateUUIDString_shouldReturnFalseWhenInvalid() {
+        final String validUUID = "not-a-uuid";
+
+        assertFalse(validateUUIDString(validUUID));
+    }
+}