Add pyi_out option to protoc command in the setup.py #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
ClemensLinnhoff
added
the
ReadyForCCBReview
PhRosenberger
approved these changes
Jun 7, 2024
jdsika
approved these changes
Jun 7, 2024
|
CCB 2024-06-10: Should be merged as soon as development on 3.7.1 starts. Inclusion into release 3.7.0 is deemed slightly too dangerous this close to release time, with potentially undetected bugs (even though fairly unlikely), want to make sure first-time PyPI release of 3.7.0 does not contain any breaking issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
#820
Add a description
Add pyi_out option to protoc command in the setup.py. This ways, IDEs recognize the modules and classes and autocorrect is supported:
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board: