[PoC] Switch Windows Signing to GoogleCloud KMS #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this switch is to save costs (only paying for a key in KMS instead of a full running hardware HSM), increase flexibility (by being able to authenticate via Identity Federation from e.g. running AWS node or GHA runner), without reducing security (key is still stored in hardware HSM in backend, non-exportable). - windows-msi: Switch signing to use jsign.jar instead of signtool to allow more flexibility in key stores. - windows-msi: Switch sign-openvpn.bat to only sign one architecture. (Cleanup) - windows-msi: Fix sign-openvpn.bat to sign openvpnmsica.dll instead of non-existant openvpnmsica.exe. (Bugfix) - windows-msi: Fix sign-openvpn.bat to not sign unit tests executables and cmocka.dll. (Cleanup) - windows-msi: Remove sign-binaries.bat intermediate script. Didn't seem to serve any purpose anymore. (Cleanup) - release: Remove AWS CloudHSM support and add GoogleCloud KMS instead. Adapt to changes in windows-msi. - .github: Implement signing of snapshot builds. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this switch is to save costs (only paying for a key in KMS instead of a full running hardware HSM), increase
flexibility (by being able to authenticate via Identity Federation from e.g. running AWS node or GHA runner), without reducing security (key is still stored in hardware HSM in backend, non-exportable).