Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray icon context menu triggers filesystem walk #664

Open
azanegin opened this issue Dec 6, 2023 · 1 comment
Open

Tray icon context menu triggers filesystem walk #664

azanegin opened this issue Dec 6, 2023 · 1 comment

Comments

@azanegin
Copy link

azanegin commented Dec 6, 2023

Misconfiguration of openvpn-gui may lead to slow appearence of contex menu.

I'm using version v11.46.0.0 but looks like its not novel.

Process Explorer shows the reason for it - each time we do right-click on a tray icon, it executes a filesystem search with unlimited depth (also ignoring convetions of exclusion of leading-dot folders) for .ovpn config files.

In my case, misconfiguration (using %HOME% folder for a config search path) lead to something akin to 5-10 second wait between a click and a menu appearing on a screen.

This results in steep drop of usabiliy. Whats worse, it is a nightmare to diagnose, because if you google "openvpn gui slow tray" and such, it fixates on "openvpn slow" part.

A simple and probably stupid fix idea would be to do the scan not before opening the context menu, but after that. Users will miss on a new config once, but will be able to already known ones.

@RazaAli99
Copy link

Hello

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants