Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: request stop by skill name #454

Open
JarbasAl opened this issue May 7, 2024 · 0 comments
Open

feat: request stop by skill name #454

JarbasAl opened this issue May 7, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JarbasAl
Copy link
Member

JarbasAl commented May 7, 2024

currently stop pipeline first checks active skill one by one to see if any wants to stop, if not then a global stop is sent

it should also be possible to request stopping a skill by name, not depending on the active order

"stop timer"
"stop wikipedia"

this could be exposed to skills a few ways

class MySkill:
     def initiallize(self):
            self.register_stop_vocab("stop.voc")

with equivalent decorator

class MySkill:

     @stop_vocab("stop.voc")
     def stop(self):
            self.register_stop_vocab("stop.voc")

default name could be derived from the class, like OCP skills do

skill_name = camel_case_split(self.__class__.__name__)
@JarbasAl JarbasAl added the enhancement New feature or request label May 7, 2024
@JarbasAl JarbasAl self-assigned this May 7, 2024
@JarbasAl JarbasAl added this to the 1.0.0 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant