From e8b5c11187a629437a9813433d5f2802f446422e Mon Sep 17 00:00:00 2001 From: miro Date: Fri, 18 Oct 2024 03:01:07 +0100 Subject: [PATCH 1/3] fix:upper case lang codes --- lingua_franca/internal.py | 5 ++++- lingua_franca/parse.py | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lingua_franca/internal.py b/lingua_franca/internal.py index af62012c..6d8afc91 100644 --- a/lingua_franca/internal.py +++ b/lingua_franca/internal.py @@ -360,7 +360,7 @@ def get_full_lang_code(lang=''): except UnsupportedLanguageError: warn(InvalidLangWarning) lang = get_default_loc() - return lang + return lang.lower() def __get_full_lang_code_deprecation_warning(lang=''): @@ -436,6 +436,8 @@ def nice_number(number, lang='', speech=True, denominators=None): "received this value:\n" + str(run_own_code_on)) # TODO deprecate these kwarg values 6-12 months after v0.3.0 releases + # TODO - deprecate the whole dynamic loading thing instead? this abandonware is hell to maintain.... + if run_own_code_on != [None]: def is_error_type(_type): if not callable(_type): @@ -495,6 +497,7 @@ def _call_localized_function(func, *args, **kwargs): # Turns out, we aren't passing a lang code at all lang_code = lang_code or get_default_lang() + lang_code = lang_code.lower() # to allow standardized lang codes with upper case if not lang_code: if load_langs_on_demand: raise ModuleNotFoundError("No language module loaded " diff --git a/lingua_franca/parse.py b/lingua_franca/parse.py index 1216e1fa..137be158 100644 --- a/lingua_franca/parse.py +++ b/lingua_franca/parse.py @@ -119,6 +119,7 @@ def extract_color_spans(text, lang=''): @localized_function(run_own_code_on=[FunctionNotLocalizedError]) def yes_or_no(text, lang=""): + lang = get_full_lang_code(lang) text = normalize(text, lang=lang, remove_articles=True).lower() return match_yes_or_no(text, lang) From b80431d9108fc234c73f9cbc9d12a9f989e72ccd Mon Sep 17 00:00:00 2001 From: miro Date: Fri, 18 Oct 2024 03:09:55 +0100 Subject: [PATCH 2/3] fix:upper case lang codes --- lingua_franca/internal.py | 1 - 1 file changed, 1 deletion(-) diff --git a/lingua_franca/internal.py b/lingua_franca/internal.py index 6d8afc91..91ec0807 100644 --- a/lingua_franca/internal.py +++ b/lingua_franca/internal.py @@ -497,7 +497,6 @@ def _call_localized_function(func, *args, **kwargs): # Turns out, we aren't passing a lang code at all lang_code = lang_code or get_default_lang() - lang_code = lang_code.lower() # to allow standardized lang codes with upper case if not lang_code: if load_langs_on_demand: raise ModuleNotFoundError("No language module loaded " From 4ea5e5b1035c41e1e080fbfe63b1e7ec5f57eb7d Mon Sep 17 00:00:00 2001 From: JarbasAI <33701864+JarbasAl@users.noreply.github.com> Date: Sat, 26 Oct 2024 18:22:49 +0100 Subject: [PATCH 3/3] Update config.py --- lingua_franca/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lingua_franca/config.py b/lingua_franca/config.py index 1ad0f5fc..6efcf4b3 100644 --- a/lingua_franca/config.py +++ b/lingua_franca/config.py @@ -1,3 +1,3 @@ -load_langs_on_demand = False +load_langs_on_demand = True inject_timezones = True ovos_defaults = True # use mycroft.conf for default values