You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @LRossman, I was wondering about the dev_pump_battery branch [1]. Apparently, some work has already been done for integrating, is there a conflict in the code we should investigate?
The history of this feature and its implementation in dev_pump_battery can be found in issue #532. In short, we agreed that it only made sense to include pump groups (i.e. batteries) if the number of active pumps could be set using both simple and rule-based controls. Since at that time we couldn't decide how to do this with the API's existing simple control functions we parked this feature in the dev_pump_battery branch.
If we were to re-visit this feature again, I would recommend getting around the limitation of the current set of EN_add/get/setcontrol functions by introducing a new set that would accommodate pump groups (e.g., EN_add/get/setpumpgroupcontrol). I originally called this approach too clunky in the prior discussion but now think it's the best option.
Hi @LRossman, I was wondering about the dev_pump_battery branch [1]. Apparently, some work has already been done for integrating, is there a conflict in the code we should investigate?
[1] dev...dev_pump_battery
The text was updated successfully, but these errors were encountered: