Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modelling of Pump groups #741

Open
eldemet opened this issue Jul 11, 2023 · 2 comments
Open

Modelling of Pump groups #741

eldemet opened this issue Jul 11, 2023 · 2 comments

Comments

@eldemet
Copy link
Contributor

eldemet commented Jul 11, 2023

Hi @LRossman, I was wondering about the dev_pump_battery branch [1]. Apparently, some work has already been done for integrating, is there a conflict in the code we should investigate?

[1] dev...dev_pump_battery

@LRossman
Copy link
Collaborator

The history of this feature and its implementation in dev_pump_battery can be found in issue #532. In short, we agreed that it only made sense to include pump groups (i.e. batteries) if the number of active pumps could be set using both simple and rule-based controls. Since at that time we couldn't decide how to do this with the API's existing simple control functions we parked this feature in the dev_pump_battery branch.

If we were to re-visit this feature again, I would recommend getting around the limitation of the current set of EN_add/get/setcontrol functions by introducing a new set that would accommodate pump groups (e.g., EN_add/get/setpumpgroupcontrol). I originally called this approach too clunky in the prior discussion but now think it's the best option.

@eldemet
Copy link
Contributor Author

eldemet commented Jul 11, 2023

Thank you @LRossman I appreciate your insights on this issue. I will check the discussion and see how we can follow-up on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants