Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multisig quorum issue #1298

Open
immrsd opened this issue Jan 13, 2025 · 0 comments
Open

Fix Multisig quorum issue #1298

immrsd opened this issue Jan 13, 2025 · 0 comments
Assignees
Milestone

Comments

@immrsd
Copy link
Collaborator

immrsd commented Jan 13, 2025

There is an issue in the Multisig component (reported by Zellic): if the remove_signers function is called with a quorum value that remains the same as the current quorum, the check ensuring quorum is less than or equal to the updated number of signers is bypassed. This can lead to the contract becoming permanently inaccessible.

@immrsd immrsd added this to the 1. current milestone Jan 13, 2025
@immrsd immrsd self-assigned this Jan 13, 2025
@immrsd immrsd moved this to 📋 Backlog in Contracts for Cairo Jan 13, 2025
@immrsd immrsd moved this from 📋 Backlog to 🏗 In progress in Contracts for Cairo Jan 13, 2025
@immrsd immrsd moved this from 🏗 In progress to 👀 In review in Contracts for Cairo Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

No branches or pull requests

1 participant