Disallow comma character as query separator, fixes issue #38

Author: kkaempf

ChangeLog

@@ -1,6 +1,9 @@
+2.4.11
 - Features
   - Bindings: EndPointReference.selector_names() for Python
 - Bugfixes
+  - URI parsing: Disallow comma to separate selectors in resource uri,
+      only ampersand is allowed. (issue #38)
   - Bindings: Fix Ruby doc generation
 
 2.4.10

src/lib/u/uri.c

@@ -218,19 +218,23 @@ hash_t *u_parse_query(const char *query)
 		dbg_err_if(key == NULL);
 
 		val = strchr(key, '=');
-		dbg_err_if(val == NULL);
+		if (val == NULL) {
+                  warn("Missing '=' character in query: %s", tok);
+                  goto err;
+                }
 
 		/* zero-term the name part and set the value pointer */
 		*val++ = 0;
 		val = u_strdup(val);
+		dbg_err_if(val == NULL);
 
 		u_trim(key);
 		u_trim(val);
 		u_trim_quotes(val);
 		if (u_string_unify(key) || u_string_unify(val)) {
 			u_free(key);
 			u_free(val);
-			dbg("Could not unify query: %s", tok);
+			warn("Could not unify %%nn sequences in query: %s", tok);
 			continue;
 		}
 		if (!hash_lookup(h, key)) {