From 1245699bb323f713d8d9eb646d8dd02a59950a9e Mon Sep 17 00:00:00 2001
From: Kyle Holmberg <kylemh.email@gmail.com>
Date: Thu, 9 Nov 2023 22:20:15 +0700
Subject: [PATCH] Fix 404 page and podcast page (#1766)

---
 .../__snapshots__/CloseButton.test.js.snap    |  2 +-
 .../__snapshots__/LinkButton.test.js.snap     |  2 +-
 .../__snapshots__/ValueCard.test.js.snap      |  2 +-
 .../__snapshots__/Content.test.js.snap        |  2 +-
 components/ErrorDisplay/ErrorDisplay.js       | 30 +++++++------------
 .../__snapshots__/ErrorDisplay.test.js.snap   | 28 ++++++++---------
 .../FeaturedJobItem.test.js.snap              |  4 +--
 .../RegistrationForm.test.js.snap             |  2 +-
 .../__snapshots__/Heading.test.js.snap        |  2 +-
 .../__snapshots__/Modal.test.js.snap          |  2 +-
 .../__snapshots__/OutboundLink.test.js.snap   |  2 +-
 .../__snapshots__/JoinSection.test.js.snap    |  4 +--
 .../SocialMediaItem.test.js.snap              |  4 +--
 next.config.js                                |  2 ++
 pages/podcast.js                              |  2 +-
 15 files changed, 39 insertions(+), 51 deletions(-)

diff --git a/components/Buttons/CloseButton/__tests__/__snapshots__/CloseButton.test.js.snap b/components/Buttons/CloseButton/__tests__/__snapshots__/CloseButton.test.js.snap
index aa95868ce..76db662e5 100644
--- a/components/Buttons/CloseButton/__tests__/__snapshots__/CloseButton.test.js.snap
+++ b/components/Buttons/CloseButton/__tests__/__snapshots__/CloseButton.test.js.snap
@@ -9,7 +9,7 @@ exports[`CloseButton should render with just required props passed 1`] = `
   type="button"
 >
   <span
-    className="ScreenReaderOnly"
+    className="sr-only"
     data-testid="SCREEN_READER_ONLY"
   >
     Close
diff --git a/components/Buttons/LinkButton/__tests__/__snapshots__/LinkButton.test.js.snap b/components/Buttons/LinkButton/__tests__/__snapshots__/LinkButton.test.js.snap
index 9541f2c75..99f0e0c8f 100644
--- a/components/Buttons/LinkButton/__tests__/__snapshots__/LinkButton.test.js.snap
+++ b/components/Buttons/LinkButton/__tests__/__snapshots__/LinkButton.test.js.snap
@@ -11,7 +11,7 @@ exports[`LinkButton should render with many props assigned 1`] = `
 >
   Test
   <span
-    className="ScreenReaderOnly"
+    className="sr-only"
     data-testid="SCREEN_READER_ONLY"
   >
     Opens in new window
diff --git a/components/Cards/ValueCard/__tests__/__snapshots__/ValueCard.test.js.snap b/components/Cards/ValueCard/__tests__/__snapshots__/ValueCard.test.js.snap
index ae4fd3fea..5c29971f4 100644
--- a/components/Cards/ValueCard/__tests__/__snapshots__/ValueCard.test.js.snap
+++ b/components/Cards/ValueCard/__tests__/__snapshots__/ValueCard.test.js.snap
@@ -2,7 +2,7 @@
 
 exports[`ValueCard should render with required props 1`] = `
 <article
-  className="Card !justify-start max-w-[400px] h-[400px] p-8 overflow-y-auto"
+  className="items-center bg-white [&_svg]:fill-secondary text-secondary flex flex-col flex-nowrap justify-around m-4 min-h-[100px] min-w-[100px] p-6 shadow-md focus-visible:outline-none !justify-start max-w-[400px] h-[400px] p-8 overflow-y-auto"
 >
   <h3
     className="text-center underline"
diff --git a/components/Content/__tests__/__snapshots__/Content.test.js.snap b/components/Content/__tests__/__snapshots__/Content.test.js.snap
index 5afc72a29..5b872145c 100644
--- a/components/Content/__tests__/__snapshots__/Content.test.js.snap
+++ b/components/Content/__tests__/__snapshots__/Content.test.js.snap
@@ -24,7 +24,7 @@ exports[`Content should render with many props assigned 1`] = `
             id="testing-link"
           >
             <span
-              className="ScreenReaderOnly"
+              className="sr-only"
               data-testid="SCREEN_READER_ONLY"
             >
               Scroll Link for 
diff --git a/components/ErrorDisplay/ErrorDisplay.js b/components/ErrorDisplay/ErrorDisplay.js
index ea234e614..c3bfbba7b 100644
--- a/components/ErrorDisplay/ErrorDisplay.js
+++ b/components/ErrorDisplay/ErrorDisplay.js
@@ -1,4 +1,3 @@
-import { useEffect } from 'react';
 import { number } from 'prop-types';
 import Head from 'components/head';
 
@@ -7,31 +6,22 @@ ErrorDisplay.propTypes = { statusCode: number };
 ErrorDisplay.defaultProps = { statusCode: undefined };
 
 function ErrorDisplay({ statusCode }) {
-  useEffect(() => {
-    document.body.style.overflowY = 'hidden';
-    return () => {
-      document.body.style.overflowY = '';
-    };
-  }, []);
-
   return (
     <>
       <Head title={statusCode ? `${statusCode}` : 'Error'}>
         <meta name="robots" content="noindex, nofollow" key={statusCode} />
       </Head>
 
-      <div className="bg-themeGray w-full h-full">
-        <div
-          className={
-            'h-[45vh] md:h-full text-white bg-[url("/static/images/TankFlip.gif")] flex flex-col justify-center w-full  bg-cover items-center'
-          }
-        >
-          <div className="text-center my-4 mx-auto">
-            <h1 className="text-6xl text-white">{statusCode || 'Oh no'}!</h1>
-            <p className="text-2xl text-white">
-              We&apos;re so ashamed. You definitely weren&apos;t supposed to see this...
-            </p>
-          </div>
+      <div
+        className={
+          'h-screen text-white bg-[url("/static/images/TankFlip.gif")] flex flex-col justify-center w-full  bg-cover items-center'
+        }
+      >
+        <div className="text-center my-4 mx-auto">
+          <h1 className="text-6xl text-white">{statusCode || 'Oh no'}!</h1>
+          <p className="text-2xl text-white">
+            We&apos;re so ashamed. You definitely weren&apos;t supposed to see this...
+          </p>
         </div>
       </div>
     </>
diff --git a/components/ErrorDisplay/__tests__/__snapshots__/ErrorDisplay.test.js.snap b/components/ErrorDisplay/__tests__/__snapshots__/ErrorDisplay.test.js.snap
index a8e5cb3b7..8db2808e9 100644
--- a/components/ErrorDisplay/__tests__/__snapshots__/ErrorDisplay.test.js.snap
+++ b/components/ErrorDisplay/__tests__/__snapshots__/ErrorDisplay.test.js.snap
@@ -2,26 +2,22 @@
 
 exports[`ErrorDisplay should render with just required props 1`] = `
 <div
-  className="bg-themeGray w-full h-full"
+  className="h-screen text-white bg-[url(\\"/static/images/TankFlip.gif\\")] flex flex-col justify-center w-full  bg-cover items-center"
 >
   <div
-    className="h-[45vh] md:h-full text-white bg-[url(\\"/static/images/TankFlip.gif\\")] flex flex-col justify-center w-full  bg-cover items-center"
+    className="text-center my-4 mx-auto"
   >
-    <div
-      className="text-center my-4 mx-auto"
+    <h1
+      className="text-6xl text-white"
     >
-      <h1
-        className="text-6xl text-white"
-      >
-        404
-        !
-      </h1>
-      <p
-        className="text-2xl text-white"
-      >
-        We're so ashamed. You definitely weren't supposed to see this...
-      </p>
-    </div>
+      404
+      !
+    </h1>
+    <p
+      className="text-2xl text-white"
+    >
+      We're so ashamed. You definitely weren't supposed to see this...
+    </p>
   </div>
 </div>
 `;
diff --git a/components/FeaturedJobItem/__tests__/__snapshots__/FeaturedJobItem.test.js.snap b/components/FeaturedJobItem/__tests__/__snapshots__/FeaturedJobItem.test.js.snap
index 7411bbc94..556391206 100644
--- a/components/FeaturedJobItem/__tests__/__snapshots__/FeaturedJobItem.test.js.snap
+++ b/components/FeaturedJobItem/__tests__/__snapshots__/FeaturedJobItem.test.js.snap
@@ -15,7 +15,7 @@ exports[`FeaturedJobItem should render with many props assigned 1`] = `
       Experienced React Engineer
     </h6>
     <span
-      className="ScreenReaderOnly"
+      className="sr-only"
       data-testid="SCREEN_READER_ONLY"
     >
       Opens in new window
@@ -99,7 +99,7 @@ exports[`FeaturedJobItem should render with required props 1`] = `
       DevOps Engineer
     </h6>
     <span
-      className="ScreenReaderOnly"
+      className="sr-only"
       data-testid="SCREEN_READER_ONLY"
     >
       Opens in new window
diff --git a/components/Forms/RegistrationForm/__tests__/__snapshots__/RegistrationForm.test.js.snap b/components/Forms/RegistrationForm/__tests__/__snapshots__/RegistrationForm.test.js.snap
index 44bf5727a..313d7fc58 100644
--- a/components/Forms/RegistrationForm/__tests__/__snapshots__/RegistrationForm.test.js.snap
+++ b/components/Forms/RegistrationForm/__tests__/__snapshots__/RegistrationForm.test.js.snap
@@ -247,7 +247,7 @@ exports[`RegistrationForm should render with required props 1`] = `
           >
             Operation Code's Code of Conduct.
             <span
-              className="ScreenReaderOnly"
+              className="sr-only"
               data-testid="SCREEN_READER_ONLY"
             >
               Opens in new window
diff --git a/components/Heading/__tests__/__snapshots__/Heading.test.js.snap b/components/Heading/__tests__/__snapshots__/Heading.test.js.snap
index 7290ab75f..d62cf2c5d 100644
--- a/components/Heading/__tests__/__snapshots__/Heading.test.js.snap
+++ b/components/Heading/__tests__/__snapshots__/Heading.test.js.snap
@@ -29,7 +29,7 @@ exports[`Heading should render with required props 1`] = `
         id="test-link"
       >
         <span
-          className="ScreenReaderOnly"
+          className="sr-only"
           data-testid="SCREEN_READER_ONLY"
         >
           Scroll Link for 
diff --git a/components/Modal/__tests__/__snapshots__/Modal.test.js.snap b/components/Modal/__tests__/__snapshots__/Modal.test.js.snap
index 9b70d8c2c..69d216e17 100644
--- a/components/Modal/__tests__/__snapshots__/Modal.test.js.snap
+++ b/components/Modal/__tests__/__snapshots__/Modal.test.js.snap
@@ -29,7 +29,7 @@ exports[`Modal should render with many props assigned 1`] = `
       type="button"
     >
       <span
-        class="ScreenReaderOnly"
+        class="sr-only"
         data-testid="SCREEN_READER_ONLY"
       >
         Close
diff --git a/components/OutboundLink/__tests__/__snapshots__/OutboundLink.test.js.snap b/components/OutboundLink/__tests__/__snapshots__/OutboundLink.test.js.snap
index 6a494035b..bb7f1f783 100644
--- a/components/OutboundLink/__tests__/__snapshots__/OutboundLink.test.js.snap
+++ b/components/OutboundLink/__tests__/__snapshots__/OutboundLink.test.js.snap
@@ -10,7 +10,7 @@ exports[`OutboundLink should render with required props 1`] = `
 >
   Test
   <span
-    className="ScreenReaderOnly"
+    className="sr-only"
     data-testid="SCREEN_READER_ONLY"
   >
     Opens in new window
diff --git a/components/ReusableSections/JoinSection/__tests__/__snapshots__/JoinSection.test.js.snap b/components/ReusableSections/JoinSection/__tests__/__snapshots__/JoinSection.test.js.snap
index bc7045826..9a6b40eb9 100644
--- a/components/ReusableSections/JoinSection/__tests__/__snapshots__/JoinSection.test.js.snap
+++ b/components/ReusableSections/JoinSection/__tests__/__snapshots__/JoinSection.test.js.snap
@@ -24,7 +24,7 @@ exports[`JoinSection should render 1`] = `
             id="join-our-thriving-community-link"
           >
             <span
-              className="ScreenReaderOnly"
+              className="sr-only"
               data-testid="SCREEN_READER_ONLY"
             >
               Scroll Link for 
@@ -61,7 +61,7 @@ exports[`JoinSection should render 1`] = `
     >
       Never heard of Slack before?
       <span
-        className="ScreenReaderOnly"
+        className="sr-only"
         data-testid="SCREEN_READER_ONLY"
       >
         Opens in new window
diff --git a/components/SocialMedia/SocialMediaItem/__tests__/__snapshots__/SocialMediaItem.test.js.snap b/components/SocialMedia/SocialMediaItem/__tests__/__snapshots__/SocialMediaItem.test.js.snap
index ab8b7d4bb..af8bb8564 100644
--- a/components/SocialMedia/SocialMediaItem/__tests__/__snapshots__/SocialMediaItem.test.js.snap
+++ b/components/SocialMedia/SocialMediaItem/__tests__/__snapshots__/SocialMediaItem.test.js.snap
@@ -12,7 +12,7 @@ exports[`SocialMediaItem should render with required props 1`] = `
     target="_blank"
   >
     <span
-      className="ScreenReaderOnly"
+      className="sr-only"
       data-testid="SCREEN_READER_ONLY"
     >
       Operation Code's 
@@ -20,7 +20,7 @@ exports[`SocialMediaItem should render with required props 1`] = `
     </span>
     <svg />
     <span
-      className="ScreenReaderOnly"
+      className="sr-only"
       data-testid="SCREEN_READER_ONLY"
     >
       Opens in new window
diff --git a/next.config.js b/next.config.js
index 80202514d..20b7bb7b6 100644
--- a/next.config.js
+++ b/next.config.js
@@ -36,6 +36,8 @@ const nextConfig = {
       s3hostName,
       'user-images.githubusercontent.com',
       'ssl-static.libsyn.com',
+      'static.libsyn.com',
+      'libsyn.com',
       'i.ytimg.com',
     ],
   },
diff --git a/pages/podcast.js b/pages/podcast.js
index 6bcf175e0..4670d5b16 100644
--- a/pages/podcast.js
+++ b/pages/podcast.js
@@ -44,7 +44,7 @@ export async function getStaticProps() {
     return { props: { episodes }, revalidate: ONE_DAY };
   }
 
-  // Request failed or RSS Feed is broken
+  // Request failed or RSS Feed is broken... Break the build!
   throw new Error('getStaticProps in /podcast failed.');
 }