Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK is unsafe? #7

Open
coccoinomane opened this issue Sep 8, 2023 · 4 comments
Open

SDK is unsafe? #7

coccoinomane opened this issue Sep 8, 2023 · 4 comments

Comments

@coccoinomane
Copy link

coccoinomane commented Sep 8, 2023

Hello,

The SDK uses a hardcoded list of makers.

The list is from 1 year ago, so it likely contains makers that are no longer active.

This is unsafe, because funds might be lost if sent to inactive makers.

I hope I am wrong. Please somebody from the team reply, to avoid loss of funds.

Thanks,
Cocco

@coccoinomane coccoinomane changed the title SDK is unsafe! SDK is unsafe? Sep 8, 2023
@coccoinomane
Copy link
Author

@Nvl977
Copy link

Nvl977 commented Dec 15, 2023

well spotted sir, have you attempted to update these makers based on latest contracts etc?

@coccoinomane
Copy link
Author

So far, I just copied the addresses of the makers from Orbiter transactions 😅

To be honest, I could not find a way to automatically parse the makers from the smart contracts. The documentation is rather obscure... Did you @Nvl977?

@Nvl977
Copy link

Nvl977 commented Dec 18, 2023

So far, I just copied the addresses of the makers from Orbiter transactions 😅

To be honest, I could not find a way to automatically parse the makers from the smart contracts. The documentation is rather obscure... Did you @Nvl977?

No annoyingly running into a good few issues with this SDK, very frustrating. I am looking to replicate the Arb -> Scroll route so will need to create a Maker for that im sure.... Will be a lot of trial and error i guess. Wish the team could just update this SDK lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants