Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Integrate with Spring Boot Admin #108

Open
andreasevers opened this issue Aug 6, 2016 · 14 comments
Open

Integrate with Spring Boot Admin #108

andreasevers opened this issue Aug 6, 2016 · 14 comments
Assignees
Labels
type: enhancement A general enhancement

Comments

@andreasevers
Copy link
Contributor

Make a visual link between the microservices and their Spring Boot Admin counterpart.

Optionally have both applications in the same Spring Boot app by using two annotations at the same time.

@TYsewyn
Copy link
Contributor

TYsewyn commented Aug 8, 2016

It appears that Spring Boot Admin and the dashboard both are using the root as context path.
We could add a dashboard specific configuration property to change the context path so that the dashboard is running on its own servlet and both applications can run next to each other.

@andreasevers
Copy link
Contributor Author

andreasevers commented Aug 8, 2016

That would be necessary indeed.

@joshiste
Copy link

I really like the idea.

@joshiste
Copy link

joshiste commented Oct 12, 2016

@andreasevers
Unfortunately until now I couldn't spent time to have a deeper look at your dashboard.

I wonder what are the parts that could to be integrated?

  • Is it just some links from your dashboard to application specific views in SBA?
  • Having a top level view in SBA that shows (an iframe?) of your dashboard?
  • Should we support running both apps in the same container? (could be cumbersome when the dependencies don't match) or does just one know of the other?
  • Do we need to exchange data for the known/registered applications?

@joshiste
Copy link

It appears that Spring Boot Admin and the dashboard both are using the root as context path.

@TYsewyn SBA doesn't register it's own dispatcherServlet. Instead it just registers some handler mappings which can be prefixed so that it is possible to run SBA not on root.

@andreasevers
Copy link
Contributor Author

Running both in the same container could get tricky indeed, and having them as separate apps wouldn't really be a problem in a microservices architecture.

We could start with some simple links, and move on from there.
Loading the dashboard visually inside the SBA would probably be not so hard to achieve since it's responsive and has a pretty simple UI. I'm normally not a fan of iframes but something along those lines should already give some nice results, benefitting both projects.

More integration isn't entirely clear to me yet. SBA has a more advanced way of dealing with services, as there is a client component sending more specific information. Microservices Dashboard only observes the services without needing a change on the services themselves. That simplifies the internals of the MD as it doesn't need a reverse proxy and so on.

@joshiste
Copy link

joshiste commented Oct 12, 2016

having them as separate apps wouldn't really be a problem in a microservices architecture.

I agree.

We could start with some simple links, and move on from there.

yep

I'm normally not a fan of iframes but something along those lines should already give some nice results, benefitting both projects.

Me neither. I think there is a neat javascript lib which can load foreign html into my page (and also does some nice tricks to crop out the right bits of html) - like an ESI / SSI but only in the browser.

@joshiste
Copy link

joshiste commented Oct 12, 2016

SBA has a more advanced way of dealing with services, as there is a client component sending more specific information. Microservices Dashboard only observes the services without needing a change on the services themselves.

Imho they both nicely complement each other. As the first one focuses on single services and the latter one on the interaction between them. Or am I wrong?

@joshiste
Copy link

joshiste commented Oct 12, 2016

Is there any way how you deal with security? Couldn't find anything on that in your reference guide...

@andreasevers
Copy link
Contributor Author

Imho they both nicely complement each other. As the first one focuses on single services and the latter one on the interaction between them. Or am I wrong?

That was our general idea when we started off with this project. SBA already existed so we didn't want to duplicate any functionality but really fill in the gaps. We want to focus on the links between microservices and refer for specific microservice details to the SBA application.

Is there anyway how you deal with security? Couldn't find anything on that in your reference guide...

Securing the dashboard itself with spring-security is straight-forward but fetching secured information hasn't been our priority yet. Definitely something on the roadmap.

@joshiste
Copy link

Securing the dashboard itself with spring-security is straight-forward but fetching secured information hasn't been our priority yet. Definitely something on the roadmap.

This is how SBA does it too.

But since it looks like spring-boot will enable security by default for the endpoints with 1.5 (even when spring-security isn't included) it's on my todo list.

@cforce
Copy link

cforce commented Apr 19, 2017

Still hoping this will happen soon

@TYsewyn
Copy link
Contributor

TYsewyn commented Feb 24, 2019

This has been put on the roadmap for 2.x.
If everything goes according to plan both SBA and the dashboard server could be added to the same application from the start of this major release.

@TYsewyn TYsewyn transferred this issue from Ordina-Group/microservices-dashboard-server Feb 25, 2019
@TYsewyn TYsewyn added the type: enhancement A general enhancement label Feb 25, 2019
@TYsewyn
Copy link
Contributor

TYsewyn commented Feb 25, 2019

Moved because of Ordina-Group/microservices-dashboard-server#82

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants