Make the db always use utf8mb4_unicode_ci #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if it helps, the database on osekai seems to use utf8mb4_bin by default for the entire database. can confirm though that the notes field is latin1_german1_ci, infact most of them are, but this seems fine in most cases? |
|
if we do the latter i'd have to do it |
EXtremeExploit
force-pushed
the
fix-notes-characters
branch
from
ef331c2
to
f4abb02
Compare
EXtremeExploit
changed the title
EXtremeExploit
force-pushed
the
fix-notes-characters
branch
from
f4abb02
to
1666886
Compare
EXtremeExploit
force-pushed
the
fix-notes-characters
branch
from
1666886
to
240a90e
Compare
|
i close this as its not using the new .sql templated and if problem ever comes i might open a new pr for it, but for the time being, its useless now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latin1_german1_cidoesn't support characters that allocate more than 2 bytes apparently, even less 4 which is for unicode ones, bututf8mb4_unicode_cidoes!. I am not sure why the default language for every other string in the db is not 4 bytes unicode, or why it is polish/latin, ig it was a fast decision to allow for some special characters but not all?, still. drafting as if thats the case then i guess it should be A LOT BETTER to directly switch the default language toutf8mb4_unicode_cito not allow for this to happen againcloses #9