-
Notifications
You must be signed in to change notification settings - Fork 3
Remove OAuth1.0 and basic authentication #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HarelM
commented
Jan 12, 2025
- Resolves Remove OAuth 1 and Basic auth #10
I think the auth hierarchy can be simplified as well as there is only one auth client... |
Maybe even unite the clients and in case no token is passed it will fail for the APIs that require authentication? |
I've simplified the hierarchy, not sure I want to unite the clients though. |
I hope that's not a breaking change? Will people need to refactor their calling code when they update? |
…face and use inheritdoc.
It's a breaking change since we removed oauth1 and basic auth clients. |
Good. I'm fixing the tests to use oauth2. |
I ended up unifying the clients code to a single class as the non auth class had some authentication in it which was odd anyway, so now everything sits in a single class now and the exposed methods are defined by the relevant interfaces. |
Add test results to ignore.
I'm not setup to run the auth tests. You're free to merge when you're ready. |
Ok, I've used my OSM token to test a trace upload and then delete. |
Seems like the Nuget token has expired and I don't think I have the relevant credentials. |
I noticed that the nuget secret had been recently updated (thanks @xivk) so I triggered the build/publish job. Nuget.org shows 1.0.5 now. |